instead please use record_exists()

• Added some empty() checks to avoid some notices about the $CFG->profilesforenrolledusersonly not defined.
• Changed get_record() to record_exists() and moved it to last condition.
• Bump 19_STABLE and HEAD versions to force the setting to be displayed/defined.

TODO:

1) I'd fix the setting help text a bit, indicating it's an anti-spam measure in some way. Right now the justification of the setting isn't clear IMO.
2) Add it to the anti SPAM Moodle Docs.
3) Backport from 19_STABLE to 1.8, 1.7 and 1.6

Helen can you take a look to 1 & 2, plz...
Dongsheng can backport it to be ready next weekly?

Thanks everybody!
Thanks and ciao

$string['configprofilesforenrolledusersonly'] = 'To prevent misuse by spammers, profile descriptions of users who are not yet enrolled in any course are hidden. New users must enrol in at least one course before they can add a profile description.';

http://docs.moodle.org/en/Site_policies
http://docs.moodle.org/en/Reducing_spam_in_Moodle

Thanks!

Ciao

I think it used to be a "security" section under "config variables" or something like that. That was the place where things like $CFG->secureforms or $CFG->loginhttps were defined... hope it helps.

• Set new setting default to true (securer).
• clean some debug code that was left there.
• fixed use of undefined $userid
• fixed logic so description field continues being mandatory for normal (enrolled) users. Was broked in prev commit.

Seems to be working fine now. Resolving as fixed. Someone else, please, review this. Ciao

PS: And please, try to perform some test when committing things to stable branches. This was simply broken in too many places to be acceptable IMO. TIA!

1/ I am not sure this should be on by default - when adding new user the description field "disappears" ??

2/ I can see this in 1.6.x when I view my own profile and description already there, but not enrolled: "This profile description will not be shown until this person is enrolled in at least one course." and not enrolled yet. This does not seem like correct English.

Anyway, reopening and going to fix more coding problems there...

Petr

2/ fixe 1x undefined $userid in 1.7.x, BUT the use of non-existent capability moodle/user:editprofile will not probably work in all cases - this was a know problem fixed in 1.8.x only - maybe it is the right time to close 1.7.x branch and not commit anything there at all

3/ in 1.8.x the new code in definition_after_data() MUST verify that $userid is valid (changed in 1.9.x) - it was removing the description field always - this was totally untested, right?

4/ the restriction does not belong into advanced user edit form - it was removing the description if user had only create user cap