Moodle

broken treeview styles in YUI 2.6

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4, 2.0
  • Component/s: Libraries
  • Labels:
    None
  • Database:
    Any
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

Moodle 1.9 updated to YUI 2.6. However, it seems like they accidentally misplaced one of their sprite files in YUI 2.6, so the treeview menu doesn't display right. I don't quite know what happened with the file, since they don't have their VCS publicly available all I know is that it was there in 2.5.2 and not in 2.6.

This is affecting the contrib block yui_menu and may affect any thing else that uses treeview. I submitted a bug report a while back (http://sourceforge.net/tracker2/?func=detail&aid=2173222&group_id=165715&atid=836476) but it has not yet been fixed.

Activity

Hide
Ashley Holman added a comment -

Hi Allan,

Can you please tell me which file I need to add back in from 2.5? I'm looking to fix this asap on some of my installations here - just upgraded to 1.9.3 and the course menus don't display correctly (screenshot attached).

Cheers

Show
Ashley Holman added a comment - Hi Allan, Can you please tell me which file I need to add back in from 2.5? I'm looking to fix this asap on some of my installations here - just upgraded to 1.9.3 and the course menus don't display correctly (screenshot attached). Cheers
Hide
Alan Trick added a comment -

Replace `treeview.css`, I believe (under lib/yui/treeview/assets/). You should be able to add that with no ill side effects. I've just replaced the whole thing with the previous version of YUI and that worked too.

Show
Alan Trick added a comment - Replace `treeview.css`, I believe (under lib/yui/treeview/assets/). You should be able to add that with no ill side effects. I've just replaced the whole thing with the previous version of YUI and that worked too.
Hide
Eloy Lafuente (stronk7) added a comment -

Assigning to Nicolas... as he knows more about the last YUI update...

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Nicolas... as he knows more about the last YUI update...
Hide
Nicolas Connault added a comment -

Copied the image where the css expects it to be. I left the original one where it was to avoid any other dependency issues (lib/yui/treeview/assets/skins/sam).

Show
Nicolas Connault added a comment - Copied the image where the css expects it to be. I left the original one where it was to avoid any other dependency issues (lib/yui/treeview/assets/skins/sam).
Hide
Nadav Kavalerchik added a comment -

related issue (workaround for rtl icons too)
http://tracker.moodle.org/browse/MDL-19769

Show
Nadav Kavalerchik added a comment - related issue (workaround for rtl icons too) http://tracker.moodle.org/browse/MDL-19769
Hide
Rossiani Wijaya added a comment -

Resolved.

Closing

Show
Rossiani Wijaya added a comment - Resolved. Closing

Dates

  • Created:
    Updated:
    Resolved: