Moodle

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9
• Fix Version/s: 2.0
• Component/s: Resource
• Labels:

  None
• Environment:

  SUSE Linux

Many problems with the following combination of technologies Moodle + Popup+ Reverse Proxy + SSL + IE + Office problems especially Office on IE7

When users click on a link to an office document the result is as explained in Microsoft KB812935 and KB316431 IE has a fit and either (displays a blank window, flashes Office (if open), pops an alert) . I made sure that Cache-Control and Pragma were blank headers for file download but no joy. Looks like the popup window headers override the file headers if the content is inline or attachment. I got pretty frustrated in fixing one method and having the other method break I ended up removing popups from office files alltogther with the following code in /lib/weblib.php this means that even if the tutor requires the file to open up in a popup window I don't allow it if it is an office extension. BTW this is aloso a good fix for the power point one blank slide issue

function link_to_popup_window ($url, $name=null, $linkname=null,
$height=400, $width=500, $title=null,
$options=null, $return=false) {

$ext = substr($url,-4,4);
if(in_array($ext,
array(
'.doc','.dot','docx','docm','dotx','dotm',
'.xls','.xla','.xlc','.xlm','.xlt','.xlw','xlsx','xlsm','xltx','xlsb','xlam',
'.ppt','.pot','.pps','pptx','pptm','potx','potm','ppam','ppsx','ppsm',
'.mdb','.clp'
))){ $isoffice = true; }
if($isoffice){ echo "<a href=".$url." >".$linkname."</a>"; }else{ return element_to_popup_window('link', $url, $name, $linkname, $height, $width, $title, $options, $return, null, null); }
}

It would be great if we could disable this functionality globally

• Assignee:

  Petr Škoda (skodak)

  Reporter:

  Kristian Thornley

  Participants:

  Kristian Thornley, Petr Škoda (skodak)

• Created:

  13/Nov/08 8:28 AM

  Updated:

  17/Dec/10 12:51 PM

  Resolved:

  11/Oct/10 5:23 PM