Moodle

Hidden Grades and Hidden Grades Capability

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Duplicate
  • Affects Version/s: 1.9.3
  • Fix Version/s: 2.0
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

There are bugs in the interactions between hidden grades, aggregation, and student view grades capability. Perhaps I am misunderstanding how these items should work, but it doesn't work as I think it should.

1) If I set the capability "View hidden grades for owner" (moodle/grade.viewhidden), the user report displays hidden grades, regardless of the settings in the course for User Report.

2) If I don't have this capability set, the hidden items are displayed or not displayed according the settings in the course for User Report, but the aggregations are affected in a funny way. Worse, the User Report I see as a Teacher has different totals than the User Report seen by the students.

3) Some aggregations are not printed in the user report, even though those items are not hidden. They should up as empty grades.

Some of the problem is the logic in moodle/grade/report/user/lib.php. The logic around line 175 depends only on the capability of viewing hidden grades and now on the course settings about whether these should be displayed. Also the logic for how hiding affects aggregate grades in the call to grade_grade::get_hiding_affected doesn't seem to be working correctly for aggregate grades.

Let me know if you have trouble reproducing this and I'll try to create a small test case for you.

Issue Links

Activity

Hide
Dominic Villiard added a comment -

I have a similar issue. Some aggregations are not printed in the user report, even though those items are hidden. But I can see those aggregations in the Activity Reports/Grade of the student. Here are some printscreen.

Show
Dominic Villiard added a comment - I have a similar issue. Some aggregations are not printed in the user report, even though those items are hidden. But I can see those aggregations in the Activity Reports/Grade of the student. Here are some printscreen.
Hide
Dominic Villiard added a comment -

This is the user report. As you can see, the total of "unite 8", "unite 9", "unite 10", "unite 11", "unite 12" are not shoting up.

Show
Dominic Villiard added a comment - This is the user report. As you can see, the total of "unite 8", "unite 9", "unite 10", "unite 11", "unite 12" are not shoting up.
Hide
Dominic Villiard added a comment -

This is the grade report in the Activity Reports. As you can see, the grades of the last unit are ahowing up.

Show
Dominic Villiard added a comment - This is the grade report in the Activity Reports. As you can see, the grades of the last unit are ahowing up.
Hide
Petr Škoda (skodak) added a comment -

HIding is a known problem, in 2.0 there will be a new option "Aggregate hidden grades", for now hidden grades are not shown to users and the calculation is adjusted too.

Show
Petr Škoda (skodak) added a comment - HIding is a known problem, in 2.0 there will be a new option "Aggregate hidden grades", for now hidden grades are not shown to users and the calculation is adjusted too.
Hide
Petr Škoda (skodak) added a comment -

resolving as duplicate, thanks for the report

Show
Petr Škoda (skodak) added a comment - resolving as duplicate, thanks for the report

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: