Moodle

Commit the finished patch

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Quiz
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Martin must be feeling paranoid today. He requested that since this is a big patch, I do the initial check-in, to minimise the chance of mistakes.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

There are a few tabs in the new code. Replace them with spaces before committing.

Show
Tim Hunt added a comment - There are a few tabs in the new code. Replace them with spaces before committing.
Hide
Permalink
Tim Hunt added a comment -

And trailing whitespace.

Show
Tim Hunt added a comment - And trailing whitespace.
Hide
Permalink
Tim Hunt added a comment -

Done!

Olli, in future, please try to be more careful with whitespace. You had a few lines with tabs, or whitespace at the end of lines, that I had to fix up. I know it is a pedantic point, but it helps everyone if you get it right. (The problem if you get is wrong, is when people are trying to merge changes.)

Show
Tim Hunt added a comment - Done! Olli, in future, please try to be more careful with whitespace. You had a few lines with tabs, or whitespace at the end of lines, that I had to fix up. I know it is a pedantic point, but it helps everyone if you get it right. (The problem if you get is wrong, is when people are trying to merge changes.)

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.