[#MDL-17288] Lang string issues - Moodle Tracker

Details

Type: Sub-task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.0
Fix Version/s: 2.0
Component/s: Quiz
Labels:
None

Affected Branches:
MOODLE_20_STABLE
Fixed Branches:
MOODLE_20_STABLE

Description

questionsperpageselected and shufflequestionsselected from lang/en_utf8/quiz.php need to use a $a, rather than concatenation.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Olli Savolainen added a comment - 21/Nov/08 10:19 PM

Hm, I added a string which contained >> instead of >>,

$string['addnewquestionsqbank'] = 'Add questions to the category $a in the \'Question bank contents\' tool >>';

but as it seems there was one already

$string['moveto'] = 'Move to >>';

I started wondering if you guys actually have a justification for this?

Show

Olli Savolainen added a comment - 21/Nov/08 10:19 PM Hm, I added a string which contained >> instead of >>, $string['addnewquestionsqbank'] = 'Add questions to the category $a in the \'Question bank contents\' tool >>'; but as it seems there was one already $string['moveto'] = 'Move to >>'; I started wondering if you guys actually have a justification for this?

Hide

Permalink

Tim Hunt added a comment - 22/Nov/08 11:05 AM

On the subject of >>, actually that is bad for accessibility. (Screen readers read that out "greater-than, greater-than, which is not good.) The correct thing to do is:

1. First make sure that you have called check_theme_arrows();
2. Then use $THEME->larrow and $THEME->rarrow with $a. Instead of < and >

I think also that check_theme_arrows does the right thing when the user is using a RTL language.

You can see an example in http://cvs.moodle.org/moodle/admin/roles/assign.php?view=markup, starting from the comment '/// Print the form'. Oh dear, bad example, it is another place where we concatenate language strings that has not been fixed.

But since there are other place that get this wrong, you don't have to fix it yourself. I'll create a new bug, assigned to me, to fix all these before the Moodle 2.0 release.

Show

Tim Hunt added a comment - 22/Nov/08 11:05 AM On the subject of >>, actually that is bad for accessibility. (Screen readers read that out "greater-than, greater-than, which is not good.) The correct thing to do is: 1. First make sure that you have called check_theme_arrows(); 2. Then use $THEME->larrow and $THEME->rarrow with $a. Instead of < and > I think also that check_theme_arrows does the right thing when the user is using a RTL language. You can see an example in http://cvs.moodle.org/moodle/admin/roles/assign.php?view=markup, starting from the comment '/// Print the form'. Oh dear, bad example, it is another place where we concatenate language strings that has not been fixed. But since there are other place that get this wrong, you don't have to fix it yourself. I'll create a new bug, assigned to me, to fix all these before the Moodle 2.0 release.

People

Assignee:

Olli Savolainen

Reporter:

Tim Hunt

Participants:

Olli Savolainen, Tim Hunt

Vote (0)

Watch (0)

Dates

Created:

19/Nov/08 2:51 PM

Updated:

17/Dec/10 12:52 PM

Resolved:

21/Nov/08 10:48 PM