Issue Details (XML | Word | Printable)

Key: MDL-17288
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Olli Savolainen
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-17284

Lang string issues

Created: 19/Nov/08 02:51 PM   Updated: 22/Nov/08 11:05 AM
Return to search
Component/s: Quiz
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Olli Savolainen and Tim Hunt
Security Level: None
Resolved date: 21/Nov/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
questionsperpageselected and shufflequestionsselected from lang/en_utf8/quiz.php need to use a $a, rather than concatenation.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Olli Savolainen added a comment - 21/Nov/08 10:19 PM
Hm, I added a string which contained >> instead of >>,

$string['addnewquestionsqbank'] = 'Add questions to the category $a in the \'Question bank contents\' tool >>';

but as it seems there was one already

$string['moveto'] = 'Move to >>';

I started wondering if you guys actually have a justification for this?


Tim Hunt added a comment - 22/Nov/08 11:05 AM
On the subject of >>, actually that is bad for accessibility. (Screen readers read that out "greater-than, greater-than, which is not good.) The correct thing to do is:

1. First make sure that you have called check_theme_arrows();
2. Then use $THEME->larrow and $THEME->rarrow with $a. Instead of < and >

I think also that check_theme_arrows does the right thing when the user is using a RTL language.

You can see an example in http://cvs.moodle.org/moodle/admin/roles/assign.php?view=markup, starting from the comment '/// Print the form'. Oh dear, bad example, it is another place where we concatenate language strings that has not been fixed.

But since there are other place that get this wrong, you don't have to fix it yourself. I'll create a new bug, assigned to me, to fix all these before the Moodle 2.0 release.