Moodle

Not all doc comments were updated

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Quiz
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

You added some new parameters, so you must update the doc comment.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Also quiz_question_preview_button. If you are feeling really good, review the whole patch to see which functions you added parameters to, and ensure you made all the necessary doc comment updates.

Show
Tim Hunt added a comment - Also quiz_question_preview_button. If you are feeling really good, review the whole patch to see which functions you added parameters to, and ensure you made all the necessary doc comment updates.
Hide
Permalink
Tim Hunt added a comment -

OK, I fixed popup_form in weblib, since you won't have access to that. However, please can you go through the patch and find the others you missed, and fix them. Thanks.

Show
Tim Hunt added a comment - OK, I fixed popup_form in weblib, since you won't have access to that. However, please can you go through the patch and find the others you missed, and fix them. Thanks.
Hide
Permalink
Olli Savolainen added a comment -

Did not update the doc comments of old functions which were already missing comments, or functions copied from such functions, but completed the docs of those that

  • I had created from scratch
  • Already had complete docs, but I had added parameters
Show
Olli Savolainen added a comment - Did not update the doc comments of old functions which were already missing comments, or functions copied from such functions, but completed the docs of those that
  • I had created from scratch
  • Already had complete docs, but I had added parameters
Hide
Permalink
Tim Hunt added a comment -

Fair enough.

Show
Tim Hunt added a comment - Fair enough.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.