[#MDL-17290] Not all doc comments were updated

Issue Details (XML | Word | Printable)

Key:	MDL-17290
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Olli Savolainen
Reporter:	Tim Hunt
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-17284

Not all doc comments were updated

Created: 19/Nov/08 02:58 PM Updated: 23/Nov/08 09:35 AM

Return to search

Component/s:

Quiz

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Olli Savolainen and Tim Hunt
Security Level:	None
Resolved date:	23/Nov/08
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

You added some new parameters, so you must update the doc comment.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Tim Hunt added a comment - 19/Nov/08 03:50 PM

Also quiz_question_preview_button. If you are feeling really good, review the whole patch to see which functions you added parameters to, and ensure you made all the necessary doc comment updates.

[ Permalink | « Hide ]

Tim Hunt added a comment - 20/Nov/08 03:41 PM

OK, I fixed popup_form in weblib, since you won't have access to that. However, please can you go through the patch and find the others you missed, and fix them. Thanks.

Tim Hunt made changes - 20/Nov/08 03:41 PM

Field	Original Value	New Value
Summary	Doc comment for popup_form in lib/weblib.php needs to be updated	Not all doc comments were updated
Component/s		Quiz [ 10059 ]
Component/s	Lib [ 10096 ]

Olli Savolainen committed 2 files to 'Moodle CVS' - 23/Nov/08 12:28 AM

quiz editing: ~~MDL-17290~~ doc comments were updated

MODIFY	mod/quiz/locallib.php		Rev. 1.164		(+15 -5 lines)
MODIFY	mod/quiz/editlib.php		Rev. 1.72		(+43 -4 lines)

[ Permalink | « Hide ]

Olli Savolainen added a comment - 23/Nov/08 12:30 AM

Did not update the doc comments of old functions which were already missing comments, or functions copied from such functions, but completed the docs of those that

I had created from scratch
Already had complete docs, but I had added parameters

Olli Savolainen made changes - 23/Nov/08 12:30 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Tim Hunt added a comment - 23/Nov/08 09:35 AM

Fair enough.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.