Issue Details (XML | Word | Printable)

Key: MDL-17291
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Olli Savolainen
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-17284

Problem on Order and Paging when paging is fixed

Created: 19/Nov/08 03:10 PM   Updated: 22/Nov/08 02:25 AM
Return to search
Component/s: Quiz
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Olli Savolainen and Tim Hunt
Security Level: None
Resolved date: 22/Nov/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
On my test quiz, I see:

Questions per page has been set so the paging is currently fixed. As a result, the paging controls have been disabled. You can change this in Update this Quiz.

Update this Quiz: Shuffle questions: No | Questions per page: 1

However, the control 'Move selected questions to page:' is not disabled.

My quiz contains 4 questions. If I select question 4, and say move to page 2, then actually it gets moved to the end of page 1.

I would expect either that control to be disabled, or for it to do what the caption says.

Questions are still moved to the wrong page, even after I change the quiz settings to allow manual page breaks.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Olli Savolainen committed 1 file to 'Moodle CVS' - 22/Nov/08 02:08 AM
quiz editing: MDL-17291 Question moving functionality to a user-selected page now manipulates an array instead of string

The old implementation was string-based and flawed, so switched to a more readable array-based one.

Also removed strpos2() since it was only used in edit.php locally and due to this change became unused.
MODIFY mod/quiz/edit.php   Rev. 1.126    (+30 -44 lines)
Olli Savolainen committed 1 file to 'Moodle CVS' - 22/Nov/08 02:22 AM
quiz editing: MDL-17291 Move selected questions to page is now disabled when Questions per page is set
MODIFY mod/quiz/editlib.php   Rev. 1.68    (+5 -5 lines)
Olli Savolainen made changes - 22/Nov/08 02:25 AM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]