| Key: |
MDL-17298
|
| Type: |
Sub-task
|
| Status: |
Resolved
|
| Resolution: |
Fixed
|
| Priority: |
Minor
|
| Assignee: |
Tim Hunt
|
| Reporter: |
Tim Hunt
|
| Votes: |
0
|
| Watchers: |
1
|
|
|
| Participants: |
Olli Savolainen and Tim Hunt
|
| Security Level: |
None
|
| Resolved date: |
25/Nov/08
|
| Affected Branches: |
MOODLE_20_STABLE
|
| Fixed Branches: |
MOODLE_20_STABLE
|
Sorry, this one is quite big. I don't know why I did not notice it before.
We really should not be adding our code to the YAHOO library namespace. I would change
YAHOO.cats.container -> question_bank
YAHOO.quiz.container -> quiz_editor
or something like that.
<div id="module" is not very descriptive. Wouldn't something like id="questionbankcontents" be better?
Do you really want to initialise on load, would onDomReady work better?
|
|
Description
|
Sorry, this one is quite big. I don't know why I did not notice it before.
We really should not be adding our code to the YAHOO library namespace. I would change
YAHOO.cats.container -> question_bank
YAHOO.quiz.container -> quiz_editor
or something like that.
<div id="module" is not very descriptive. Wouldn't something like id="questionbankcontents" be better?
Do you really want to initialise on load, would onDomReady work better? |
Show » |
committed 1 file to 'Moodle CVS' - 23/Nov/08 02:20 AM
quiz editing: MDL-17298 use onDOMReady instead of onload.
In the previous commit to this file (1.2) I accidentally tried to do this already, but did it wrong, so javascript dialogs did not work.
|
|
|
committed 1 file to 'Moodle CVS' - 23/Nov/08 02:26 AM
quiz editing: MDL-17298 removed debugging code forgotten there in the previous revision
|
|
|
tjhunt committed 2 files to 'Moodle CVS' - 25/Nov/08 09:31 PM
quiz editing: MDL-17298 We should not add JavaScript to the YAHOO namespace
Also, use the newer methods for including required JavaScript.
|
|
|
|
