[#MDL-17302] Turn quiz_question_showbank and question_showbank into a class and subclass

Issue Details (XML | Word | Printable)

Key:	MDL-17302
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Tim Hunt
Reporter:	Tim Hunt
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-16345

Turn quiz_question_showbank and question_showbank into a class and subclass

Created: 19/Nov/08 05:41 PM Updated: 22/Jan/09 02:43 PM

Component/s:

Questions, Quiz

Affects Version/s:

2.0

Fix Version/s:

2.0

Issue Links:

Relates

This issue has been marked as being related by:

MDL-17284 Add Olli's new quiz editing UI to Moodle 2.0

Participants:	Tim Hunt
Security Level:	None
Resolved date:	22/Jan/09
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

Left over from MDL-17284, but since I have to work on the questionbank anyway, I'll do it.

All

Comments

Change History

Version Control

Sort Order:

Tim Hunt made changes - 19/Nov/08 05:42 PM

Field	Original Value	New Value
Link		This issue has been marked as being related by MDL-17284 [ MDL-17284 ]

Tim Hunt made changes - 13/Jan/09 06:14 PM

Summary

Refactor away mostly duplicated code in quiz_question_showbank in mod/quiz/editlib.php

Turn quiz_question_showbank and question_showbank into a class and subclass

tjhunt committed 4 files to 'Moodle CVS' - 19/Jan/09 02:30 PM

question bank: ~~MDL-17302~~ refactor question bank display code into a class.

Step 1. Just convert the existing functions quiz_question_showbank and question_showbank and friends into methods of a class and subclass.

More to come.

MODIFY	question/edit.php	Rev. 1.22	(+32 -11 lines)
MODIFY	mod/quiz/editlib.php	Rev. 1.101	(+427 -400 lines)
MODIFY	question/editlib.php	Rev. 1.99	(+492 -446 lines)
MODIFY	mod/quiz/edit.php	Rev. 1.142	(+32 -13 lines)

tjhunt committed 2 files to 'Moodle CVS' - 19/Jan/09 05:50 PM

question bank: ~~MDL-17302~~ refactor question bank display code into a class.

Step 2. Remove as many as possbile of the differences between the two classes. This is mostly whitespace and irrelevant code formatting issues, but there are also a few changes to the generated output, taking the best of both views.

MODIFY	mod/quiz/editlib.php		Rev. 1.102		(+99 -132 lines)
MODIFY	question/editlib.php		Rev. 1.100		(+105 -72 lines)

tjhunt committed 2 files to 'Moodle CVS' - 21/Jan/09 05:49 PM

question bank: ~~MDL-17302~~ refactor question bank display code into a class.

Step 3. Start working ot the code to initialise things from a list of columns, and build the corresponding SQL query.

MODIFY	question/editlib.php		Rev. 1.103		(+143 -2 lines)
MODIFY	lang/en_utf8/error.php		Rev. 1.162		(+2 -1 lines)

tjhunt committed 1 file to 'Moodle CVS' - 21/Jan/09 05:52 PM

question bank: ~~MDL-17302~~ fix errors in the previous commit.

MODIFY

question/editlib.php

Rev. 1.104

(+14 -14 lines)

Mitsuhiro Yoshida committed 5 files to 'Lang CVS' - 22/Jan/09 08:18 AM

~~MDL-17889~~ Translated a new string for tag.
~~MDL-14992~~ ~~MDL-17302~~ ~~MDL-17942~~ Translated new strings for error messages.
~~MDL-17364~~ Translated a new string for forum ajax rating.
~~MDL-16651~~ Translated a new string for scorm.

MODIFY	ja_utf8/forum.php	Rev. 1.83	(+3 -1 lines)
MODIFY	ja_utf8/README	Rev. 1.922	(+1 -1 lines)
MODIFY	ja_utf8/scorm.php	Rev. 1.44	(+2 -1 lines)
MODIFY	ja_utf8/tag.php	Rev. 1.19	(+2 -1 lines)
MODIFY	ja_utf8/error.php	Rev. 1.118	(+4 -0 lines)

[ Permalink | « Hide ]

Tim Hunt added a comment - 22/Jan/09 02:43 PM

Right. Most of the duplicate code gone. I am deeming this part done. Further changes can be covered by other subtasks of MDL-16345.

Tim Hunt made changes - 22/Jan/09 02:43 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

martignoni committed 1 file to 'Lang CVS' - 24/Jan/09 04:57 AM

~~MDL-17302~~ new string

MODIFY

fr_utf8/error.php

Rev. 1.164

(+2 -1 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.