Details
Bug
Closed
Major
Description
It seems that the recent commit by user "samulik" contains several damaged files. Instead of proper PHP string files, the files contain something like:
Warning: require(../fi_utf8/block_search.php): failed to open stream: No such file or directory in /home/samulik/kaannos/langdiff.php on line 105
Fatal error: require(): Failed opening required '../fi_utf8/block_search.php' (include_path='.:/usr/share/php:/usr/share/pear') in /home/samulik/kaannos/langdiff.php on line 105
See e.g. http://cvs.moodle.org/lang/fi_utf8/block_search.php, revision 1.1
According to my grep, the following files contain "Warning:" string:
block_search.php
block_tag_flickr.php
bulkusers.php
qtype_match.php
qtype_randomsamatch.php
search.php
userkey.php
Please fix asap as this breaks some language manipulation tools. Thanks
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
My bad, sorry! Forgot to copy the new files manually, and the merging script that I used replaced them with an error message. I verified the commit with "cvs diff" but didn't (know to) use the -N switch, so it didn't report anything for the new files 
Replaced the broken files with correct new language files. Have to remember to use "cvs diff -N" in the future!
Replaced the broken files with correct new language files. Have to remember to use "cvs diff -N" in the future! There are some more newly introduced errors in the language pack. No blockers, but better to be fixed:
fi_utf8/forum.php: Warning - "$a->forumref" in discussionmovedpost may not be ok, allowed options are: $a->discusshref, $a->forumhref, $a->forumname
fi_utf8/lesson.php: Warning - "$a->maxhighscores" in topscorestitle may not be ok, allowed options are: $a
fi_utf8/lesson.php: Warning - "$a->name" in topscorestitle may not be ok, allowed options are: $a
fi_utf8/moodle.php: ERROR - Malformed passwordsenttext mixed $a and $a->, allowed options are: $a->email, $a->link
fi_utf8/quiz_grading.php: Warning - "$a->fullename" in gradingattempt may not be ok, allowed options are: $a->attempt, $a->fullname
See MDL-14152 for a script that helps verifying the translation before submitting 
Ok, good to know about that script! Maybe it could be incorporated in the language pack editing UI somewhere?
The script told me:
"en_utf8/notes.php: ERROR - Trailing or leading whitespace problem detected in main English lang pack!!!!
0 errors found "
" Just noticed MDL-17356, so the notes.php issue is probably ok now. The "0 errors " thing still remains, but it's quite trivial 
" thing still remains, but it's quite trivial 
JIRA auto-linking includes comma at the end of the CVS link above. The correct URL is http://cvs.moodle.org/lang/fi_utf8/block_search.php