[#MDL-17350] fi_utf8 language pack broken

Issue Details (XML | Word | Printable)

Key:	MDL-17350
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Koen Roggemans
Reporter:	David Mudrak
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

fi_utf8 language pack broken

Created: 22/Nov/08 12:04 AM Updated: 22/Nov/08 11:50 AM

Return to search

Component/s:

Languages

Affects Version/s:

1.9.3

Fix Version/s:

1.9.3

Participants:	David Mudrak, Koen Roggemans and Samuli Karevaara
Security Level:	None
Resolved date:	22/Nov/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

It seems that the recent commit by user "samulik" contains several damaged files. Instead of proper PHP string files, the files contain something like:

Warning: require(../fi_utf8/block_search.php): failed to open stream: No such file or directory in /home/samulik/kaannos/langdiff.php on line 105

Fatal error: require(): Failed opening required '../fi_utf8/block_search.php' (include_path='.:/usr/share/php:/usr/share/pear') in /home/samulik/kaannos/langdiff.php on line 105

See e.g. http://cvs.moodle.org/lang/fi_utf8/block_search.php, revision 1.1

According to my grep, the following files contain "Warning:" string:
block_search.php
block_tag_flickr.php
bulkusers.php
qtype_match.php
qtype_randomsamatch.php
search.php
userkey.php

Please fix asap as this breaks some language manipulation tools. Thanks

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

David Mudrak added a comment - 22/Nov/08 12:06 AM

JIRA auto-linking includes comma at the end of the CVS link above. The correct URL is http://cvs.moodle.org/lang/fi_utf8/block_search.php

Samuli Karevaara committed 8 files to 'Lang CVS' - 22/Nov/08 04:32 AM

~~MDL-17350~~ Replacing broken language files with correct ones.

MODIFY	fi_utf8/userkey.php	Rev. 1.2	(+18 -4 lines)
MODIFY	fi_utf8/help/picture.html	Rev. 1.2	(+2 -3 lines)
MODIFY	fi_utf8/qtype_match.php	Rev. 1.2	(+10 -4 lines)
MODIFY	fi_utf8/bulkusers.php	Rev. 1.2	(+23 -4 lines)
MODIFY	fi_utf8/search.php	Rev. 1.2	(+61 -4 lines)
MODIFY	fi_utf8/block_search.php	Rev. 1.2	(+20 -4 lines)
MODIFY	fi_utf8/block_tag_flickr.php	Rev. 1.2	(+21 -4 lines)
MODIFY	fi_utf8/qtype_randomsamatch.php	Rev. 1.2	(+9 -4 lines)

[ Permalink | « Hide ]

Samuli Karevaara added a comment - 22/Nov/08 04:39 AM

My bad, sorry! Forgot to copy the new files manually, and the merging script that I used replaced them with an error message. I verified the commit with "cvs diff" but didn't (know to) use the -N switch, so it didn't report anything for the new files

Replaced the broken files with correct new language files. Have to remember to use "cvs diff -N" in the future!

Samuli Karevaara made changes - 22/Nov/08 04:39 AM

Field	Original Value	New Value
Fix Version/s		1.9.3 [ 10290 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Koen Roggemans added a comment - 22/Nov/08 05:19 AM

There are some more newly introduced errors in the language pack. No blockers, but better to be fixed:

fi_utf8/forum.php: Warning - "$a->forumref" in discussionmovedpost may not be ok, allowed options are: $a->discusshref, $a->forumhref, $a->forumname
fi_utf8/lesson.php: Warning - "$a->maxhighscores" in topscorestitle may not be ok, allowed options are: $a
fi_utf8/lesson.php: Warning - "$a->name" in topscorestitle may not be ok, allowed options are: $a
fi_utf8/moodle.php: ERROR - Malformed passwordsenttext mixed $a and $a->, allowed options are: $a->email, $a->link
fi_utf8/quiz_grading.php: Warning - "$a->fullename" in gradingattempt may not be ok, allowed options are: $a->attempt, $a->fullname

See ~~MDL-14152~~ for a script that helps verifying the translation before submitting

Koen Roggemans made changes - 22/Nov/08 05:19 AM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

Koen Roggemans made changes - 22/Nov/08 05:19 AM

Priority

Blocker [ 1 ]

Major [ 3 ]

Samuli Karevaara committed 4 files to 'Lang CVS' - 22/Nov/08 11:36 AM

~~MDL-17350~~ Fixing issues reported by lang_fix.php

MODIFY	fi_utf8/lesson.php	Rev. 1.15	(+3 -3 lines)
MODIFY	fi_utf8/quiz_grading.php	Rev. 1.7	(+3 -3 lines)
MODIFY	fi_utf8/moodle.php	Rev. 1.34	(+3 -3 lines)
MODIFY	fi_utf8/forum.php	Rev. 1.18	(+3 -3 lines)

[ Permalink | « Hide ]

Samuli Karevaara added a comment - 22/Nov/08 11:41 AM

Ok, good to know about that script! Maybe it could be incorporated in the language pack editing UI somewhere?

The script told me:
"en_utf8/notes.php: ERROR - Trailing or leading whitespace problem detected in main English lang pack!!!!

0 errors found "

Samuli Karevaara made changes - 22/Nov/08 11:41 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Samuli Karevaara added a comment - 22/Nov/08 11:50 AM

Just noticed ~~MDL-17356~~, so the notes.php issue is probably ok now. The "0 errors

" thing still remains, but it's quite trivial

All content on this web site is made available under the GNU General Public License, unless otherwise stated.