Issue Details (XML | Word | Printable)

Key: MDL-17359
Type: Task Task
Status: Open Open
Priority: Minor Minor
Assignee: moodle.com
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Review the language files, and fix all the places we are using < and > as arrows in language strings

Created: 22/Nov/08 11:07 AM   Updated: 28/Nov/08 08:29 PM
Return to search
Component/s: Accessibility, Languages
Affects Version/s: 2.0
Fix Version/s: 2.0

Issue Links:
Relates
 

Participants: moodle.com, Olli Savolainen and Tim Hunt
Security Level: None
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
This is bad for screen-reader users.

If I can find an effective regex, and I can be bothered, I might go beyond the quiz.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Tim Hunt added a comment - 25/Nov/08 09:44 PM
We seem to be OK on <. I checked with the regexp

<(?Unable to render embedded object: File (?[pP][hH][pP])(?) not found..*>)

which finds unmatched < that are not part of an open PHP tag. There are about a dozen in the lang files, all of which are HTML tags in help files wrapped over two lines, except for string addrandom1 in quiz.php, which is no longer used anywhere.


Tim Hunt added a comment - 25/Nov/08 10:14 PM
There are bad > characters in

admin.php string importlangreminder
editor.php string cutpastemozilla
enrol_authroize.php strings logindesc,

They should be replaced by $THEME->rarrow, after calling check_theme_arrows(). This is an accessibility thing.

The quiz string Move to >> is no longer used anywhere.

I have fixed the one genuine occurrence in quiz.php.


tjhunt committed 3 files to 'Moodle CVS' - 25/Nov/08 10:15 PM
accessibility / lang strings: MDL-17359 remove > being used as an arrow - screen readers don't like it.
MODIFY lang/en_utf8/moodle.php   Rev. 1.212    (+2 -2 lines)
MODIFY mod/quiz/editlib.php   Rev. 1.73    (+7 -4 lines)
MODIFY lang/en_utf8/quiz.php   Rev. 1.119    (+2 -2 lines)
Tim Hunt added a comment - 25/Nov/08 10:16 PM
Reassigning, to let the people who maintain those bits of the code fix the remaining occurrences.

Tim Hunt made changes - 25/Nov/08 10:16 PM
Field Original Value New Value
Assignee Tim Hunt [ timhunt ] moodle.com [ moodle.com ]
Component/s Quiz [ 10059 ]
Component/s Accessibility [ 10083 ]
Component/s Questions [ 10087 ]
Olli Savolainen added a comment - 26/Nov/08 10:28 PM - edited
Tim, in revision 1.73 you seem to have added the following in /mod/quiz/editlib.php, around line 831:

$a = new stdClass;
$a->catname = '<strong>' . $category->name . '</strong>';
$a->arrow = $THEME->rarrow;
echo get_string('addnewquestionsqbank','quiz', $a);

This seems to cause the following in function get_string(), breaking the UI:

Catchable fatal error: Object of class stdClass could not be converted to string in /home/olli/workspace/moodle2cvs/lib/moodlelib.php(5435) : eval()'d code on line 1

I am not familiar with this way of using get_string, so I don't know how to fix it.


Tim Hunt added a comment - 26/Nov/08 11:35 PM
Did you CVS-update everything? (In particular, including the language file) It works for me, but I did change the lang string. (Since it is a very recently introduce string, that is OK.)

Mitsuhiro Yoshida committed 6 files to 'Lang CVS' - 27/Nov/08 03:49 AM
MDL-15326 Translated new strings for quiz and quiz stat.
MDL-17359 Updated translated strings.
MDL-14155 Updated a translated srring for lesson.
Fixed a typo in dbtransfer.php based on lang/en_utf8 fix.
MODIFY ja_utf8/quiz_statistics.php   Rev. 1.18    (+3 -1 lines)
MODIFY ja_utf8/README   Rev. 1.877    (+1 -1 lines)
MODIFY ja_utf8/quiz.php   Rev. 1.166    (+4 -2 lines)
MODIFY ja_utf8/lesson.php   Rev. 1.76    (+2 -2 lines)
MODIFY ja_utf8/moodle.php   Rev. 1.330    (+2 -2 lines)
MODIFY ja_utf8/dbtransfer.php   Rev. 1.2    (+2 -2 lines)
Olli Savolainen added a comment - 28/Nov/08 08:28 PM
Oh, I guess it was my bad. Sorry for the disturbance.

Olli Savolainen made changes - 28/Nov/08 08:29 PM
Link This issue has a non-specific relationship to MDL-17284 [ MDL-17284 ]
martignoni committed 1 file to 'Lang CVS' - 07/Dec/08 11:41 PM
MDL-17359 Arrow modified
MODIFY fr_utf8/quiz.php   Rev. 1.128    (+2 -2 lines)