Moodle

Add full plugin support for course and admin reports

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4
  • Component/s: Course
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

We need separate view capabilities for each course report:

course/report/xx/db/access.php
course/report/xx/version.php

The admin reports need caps too.

Attachments

  1. Text File
    reports_12.patch
    24/Nov/08 8:14 AM
    92 kB
    Petr Škoda (skodak)
  2. Text File
    reports_14.patch
    24/Nov/08 4:20 PM
    94 kB
    Petr Škoda (skodak)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

Sending patch for review:

1/ added full plugin support to course reports - new view capability for each report, 'moodle/site:viewreports' is needed for link in admin block and user profile only
2/ added full plugin support to admin reports
3/ renamed admin/simpletest report to admin/unittest - already done in HEAD

Show
Petr Škoda (skodak) added a comment - Sending patch for review: 1/ added full plugin support to course reports - new view capability for each report, 'moodle/site:viewreports' is needed for link in admin block and user profile only 2/ added full plugin support to admin reports 3/ renamed admin/simpletest report to admin/unittest - already done in HEAD
Hide
Permalink
Tim Hunt added a comment -

Re: 3) You made the same mistakes as was made in MDL-17001. Please see MDL-17367 for the bits that are missing.

Show
Tim Hunt added a comment - Re: 3) You made the same mistakes as was made in MDL-17001. Please see MDL-17367 for the bits that are missing.
Hide
Permalink
Petr Škoda (skodak) added a comment -

thanks Tim

Show
Petr Škoda (skodak) added a comment - thanks Tim
Hide
Permalink
Petr Škoda (skodak) added a comment -

I have decided to commit smaller parts, first refactoring existing code then adding new caps - it should be much easier to review new strings/caps

Show
Petr Škoda (skodak) added a comment - I have decided to commit smaller parts, first refactoring existing code then adding new caps - it should be much easier to review new strings/caps
Hide
Permalink
Petr Škoda (skodak) added a comment -

done

Show
Petr Škoda (skodak) added a comment - done
Hide
Permalink
Petr Škoda (skodak) added a comment -

fixed regression in 3rd party report - reported by Eloy thanks

Show
Petr Škoda (skodak) added a comment - fixed regression in 3rd party report - reported by Eloy thanks

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.