[#MDL-17372] Add full plugin support for course and admin reports

Issue Details (XML | Word | Printable)

Key:	MDL-17372
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	3

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-17205

Add full plugin support for course and admin reports

Created: 24/Nov/08 08:07 AM Updated: 07/Dec/08 05:44 AM

Return to search

Component/s:

Course

Affects Version/s:

1.9.3

Fix Version/s:

1.9.4

File Attachments:

reports_12.patch (92 kB)
2.

reports_14.patch (94 kB)

Participants:	Petr Skoda and Tim Hunt
Security Level:	None
Resolved date:	29/Nov/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

We need separate view capabilities for each course report:

course/report/xx/db/access.php
course/report/xx/version.php

The admin reports need caps too.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Petr Skoda added a comment - 24/Nov/08 08:14 AM

Sending patch for review:

1/ added full plugin support to course reports - new view capability for each report, 'moodle/site:viewreports' is needed for link in admin block and user profile only
2/ added full plugin support to admin reports
3/ renamed admin/simpletest report to admin/unittest - already done in HEAD

[ Permalink | « Hide ]

Tim Hunt added a comment - 24/Nov/08 10:17 AM

Re: 3) You made the same mistakes as was made in ~~MDL-17001~~. Please see ~~MDL-17367~~ for the bits that are missing.

[ Permalink | « Hide ]

Petr Skoda added a comment - 24/Nov/08 04:20 PM

thanks Tim

[ Permalink | « Hide ]

Petr Skoda added a comment - 27/Nov/08 06:09 AM

I have decided to commit smaller parts, first refactoring existing code then adding new caps - it should be much easier to review new strings/caps

[ Permalink | « Hide ]

Petr Skoda added a comment - 29/Nov/08 11:17 PM

done

[ Permalink | « Hide ]

Petr Skoda added a comment - 07/Dec/08 05:44 AM

fixed regression in 3rd party report - reported by Eloy

thanks

All content on this web site is made available under the GNU General Public License, unless otherwise stated.