Issue Details (XML | Word | Printable)

Key: MDL-17372
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-17205

Add full plugin support for course and admin reports

Created: 24/Nov/08 08:07 AM   Updated: 07/Dec/08 05:44 AM
Return to search
Component/s: Course
Affects Version/s: 1.9.3
Fix Version/s: 1.9.4

File Attachments: 1. Text File reports_12.patch (92 kB)
2. Text File reports_14.patch (94 kB)

Participants: Petr Skoda and Tim Hunt
Security Level: None
Resolved date: 29/Nov/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
We need separate view capabilities for each course report:

course/report/xx/db/access.php
course/report/xx/version.php

The admin reports need caps too.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda made changes - 24/Nov/08 08:09 AM
Field Original Value New Value
Description We need separate view capabilities for each course report:

course/report/xx/db/access.php
course/report/xx/version.php 		We need separate view capabilities for each course report:

course/report/xx/db/access.php
course/report/xx/version.php

The admin reports need caps too.
Summary Add full plugin support for course reports Add full plugin support for course and admin reports
[ Permalink | « Hide ]
Petr Skoda added a comment - 24/Nov/08 08:14 AM
Sending patch for review:

1/ added full plugin support to course reports - new view capability for each report, 'moodle/site:viewreports' is needed for link in admin block and user profile only
2/ added full plugin support to admin reports
3/ renamed admin/simpletest report to admin/unittest - already done in HEAD


Petr Skoda made changes - 24/Nov/08 08:14 AM
Attachment reports_12.patch [ 15718 ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 24/Nov/08 10:17 AM
Re: 3) You made the same mistakes as was made in MDL-17001. Please see MDL-17367 for the bits that are missing.

Petr Skoda made changes - 24/Nov/08 04:20 PM
Attachment reports_14.patch [ 15720 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 24/Nov/08 04:20 PM
thanks Tim

Petr Skoda committed 22 files to 'Moodle CVS' - 27/Nov/08 04:27 AM
MDL-17372 admin reports: Added full plugin support for admin reports; added specail capability for unittest execution, minor refactoring
ADD admin/report/questioninstances/settings.php   Rev. 1.1    (+0 -0 lines)
MODIFY admin/report/unittest/settings.php   Rev. 1.3    (+3 -3 lines)
MODIFY admin/report/courseoverview/index.php   Rev. 1.25    (+2 -5 lines)
MODIFY version.php   Rev. 1.895    (+1 -1 lines)
MODIFY admin/report/questioninstances/index.php   Rev. 1.3    (+5 -10 lines)
ADD admin/settings/Attic/report.php   Rev. 1.1    (+0 -0 lines)
MODIFY lib/accesslib.php   Rev. 1.549    (+12 -2 lines)
ADD admin/report/log/settings.php   Rev. 1.1    (+0 -0 lines)
MODIFY admin/report/stats/Attic/index.php   Rev. 1.17    (+8 -14 lines)
MODIFY admin/settings/top.php   Rev. 1.26    (+6 -1 lines)
ADD lang/en_utf8/report_unittest.php   Rev. 1.1    (+0 -0 lines)
MODIFY admin/report/log/Attic/index.php   Rev. 1.6    (+1 -2 lines)
ADD admin/report/unittest/version.php   Rev. 1.1    (+0 -0 lines)
ADD admin/report/courseoverview/settings.php   Rev. 1.1    (+0 -0 lines)
MODIFY admin/report/unittest/dbtest.php   Rev. 1.3    (+5 -7 lines)
MODIFY admin/report/stats/settings.php   Rev. 1.2    (+2 -4 lines)
MODIFY lib/accesslib.php   Rev. 1.550    (+5 -2 lines)
MODIFY admin/settings/users.php   Rev. 1.39    (+1 -5 lines)
MODIFY admin/report/unittest/index.php   Rev. 1.4    (+7 -9 lines)
MODIFY admin/report/backups/index.php   Rev. 1.8    (+3 -6 lines)
ADD admin/report/unittest/db/access.php   Rev. 1.1    (+0 -0 lines)
MODIFY lib/adminlib.php   Rev. 1.288    (+1 -16 lines)
Mitsuhiro Yoshida committed 1 file to 'Lang CVS' - 27/Nov/08 04:47 AM
MDL-17372 Adding a translated lang file for unittest report.
ADD ja_utf8/report_unittest.php   Rev. 1.1    (+0 -0 lines)
Petr Skoda committed 28 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 27/Nov/08 05:58 AM
MDL-17372 admin reports: Added full plugin support for admin reports; added specail capability for unittest execution, minor refactoring - backported from HEAD
MODIFY admin/report/unittest/ex_reporter.php   Rev. 1.1.2.2    (+196 -0 lines)
MODIFY admin/report/question/Attic/index.php   Rev. 1.3.2.2    (+2 -2 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.516.2.66    (+2 -2 lines)
MODIFY admin/report/unittest/db/access.php   Rev. 1.1.2.2    (+40 -0 lines)
MODIFY admin/report/unittest/settings.php   Rev. 1.3.2.2    (+3 -0 lines)
MODIFY admin/report/log/Attic/index.php   Rev. 1.5.4.1    (+1 -2 lines)
DEL admin/report/simpletest/Attic/ex_simple_test.php   Rev. 1.4.4.1    (+0 -0 lines)
MODIFY admin/report/courseoverview/settings.php   Rev. 1.1.2.2    (+3 -0 lines)
MODIFY lib/accesslib.php   Rev. 1.421.2.81    (+16 -3 lines)
MODIFY admin/report/question/Attic/settings.php   Rev. 1.1.2.1    (+3 -0 lines)
MODIFY admin/report/unittest/index.php   Rev. 1.4.2.2    (+108 -0 lines)
MODIFY lib/moodlelib.php   Rev. 1.960.2.105    (+3 -3 lines)
MODIFY admin/report/stats/Attic/index.php   Rev. 1.12.4.2    (+8 -6 lines)
MODIFY lang/en_utf8/report_unittest.php   Rev. 1.1.2.2    (+5 -0 lines)
MODIFY admin/report/backups/settings.php   Rev. 1.1.2.2    (+3 -0 lines)
MODIFY theme/standard/styles_color.css   Rev. 1.149.2.18    (+8 -8 lines)
MODIFY admin/report/courseoverview/index.php   Rev. 1.16.4.4    (+2 -5 lines)
MODIFY version.php   Rev. 1.563.2.322    (+1 -1 lines)
MODIFY admin/settings/Attic/report.php   Rev. 1.1.2.2    (+18 -0 lines)
MODIFY admin/settings/users.php   Rev. 1.26.2.9    (+1 -5 lines)
DEL admin/report/simpletest/Attic/index.php   Rev. 1.11.4.2    (+0 -0 lines)
MODIFY admin/report/stats/settings.php   Rev. 1.2.2.2    (+3 -0 lines)
MODIFY admin/report/log/settings.php   Rev. 1.1.2.2    (+3 -0 lines)
MODIFY admin/report/unittest/ex_simple_test.php   Rev. 1.1.2.2    (+210 -0 lines)
MODIFY admin/settings/top.php   Rev. 1.15.2.7    (+4 -23 lines)
MODIFY admin/report/unittest/version.php   Rev. 1.1.2.2    (+29 -0 lines)
MODIFY admin/report/backups/index.php   Rev. 1.2.2.3    (+3 -6 lines)
DEL admin/report/simpletest/Attic/ex_reporter.php   Rev. 1.10.2.1    (+0 -0 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 27/Nov/08 06:09 AM
I have decided to commit smaller parts, first refactoring existing code then adding new caps - it should be much easier to review new strings/caps

Petr Skoda committed 8 files to 'Moodle CVS' - 28/Nov/08 05:30 AM
MDL-17372 course reports: Added full plugin support for course reports
MODIFY course/report/outline/mod.php   Rev. 1.5    (+8 -6 lines)
MODIFY course/report.php   Rev. 1.10    (+13 -7 lines)
MODIFY course/report/participation/mod.php   Rev. 1.9    (+7 -6 lines)
MODIFY lib/adminlib.php   Rev. 1.289    (+4 -1 lines)
MODIFY course/report/log/mod.php   Rev. 1.8    (+9 -8 lines)
MODIFY lib/accesslib.php   Rev. 1.551    (+16 -2 lines)
MODIFY course/report/progress/mod.php   Rev. 1.2    (+9 -7 lines)
MODIFY course/report/stats/mod.php   Rev. 1.7    (+12 -10 lines)
Petr Skoda committed 7 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 28/Nov/08 05:31 AM
MDL-17372 course reports: Added full plugin support for course reports - backported from HEAD
MODIFY admin/index.php   Rev. 1.286.2.25    (+4 -1 lines)
MODIFY course/report/participation/mod.php   Rev. 1.7.2.2    (+8 -7 lines)
MODIFY course/report/stats/mod.php   Rev. 1.6.4.1    (+11 -9 lines)
MODIFY course/report/log/mod.php   Rev. 1.7.4.1    (+9 -8 lines)
MODIFY course/report.php   Rev. 1.6.2.1    (+14 -7 lines)
MODIFY course/report/outline/mod.php   Rev. 1.4.4.1    (+8 -6 lines)
MODIFY lib/accesslib.php   Rev. 1.421.2.82    (+16 -2 lines)
Petr Skoda committed 5 files to 'Moodle CVS' - 28/Nov/08 05:04 PM
MDL-17372 admin reports: Added full plugin support for admin reports - fixed sorting regression, plugins now loaded as last category
MODIFY admin/settings/plugins.php   Rev. 1.33    (+24 -1 lines)
MODIFY lib/adminlib.php   Rev. 1.290    (+9 -3 lines)
MODIFY admin/settings/top.php   Rev. 1.27    (+1 -4 lines)
MODIFY admin/settings/users.php   Rev. 1.40    (+4 -0 lines)
DEL admin/settings/Attic/report.php   Rev. 1.2    (+0 -0 lines)
Petr Skoda committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 28/Nov/08 05:12 PM
MDL-17372 admin reports: Added full plugin support for admin reports - fixed sorting regression, plugins now loaded as last category; backported from HEAD
MODIFY admin/settings/users.php   Rev. 1.26.2.10    (+4 -0 lines)
MODIFY admin/settings/top.php   Rev. 1.15.2.8    (+1 -4 lines)
MODIFY lib/adminlib.php   Rev. 1.153.2.55    (+10 -3 lines)
MODIFY admin/settings/plugins.php   Rev. 1.1.2.7    (+19 -2 lines)
DEL admin/settings/Attic/report.php   Rev. 1.1.2.3    (+0 -0 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 29/Nov/08 11:17 PM
done

Petr Skoda made changes - 29/Nov/08 11:17 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 30/Nov/08 01:28 AM
MDL-17372 new course reports string - role definition improvement
MODIFY lib/accesslib.php   Rev. 1.421.2.83    (+2 -2 lines)
MODIFY lang/en_utf8/moodle.php   Rev. 1.141.2.47    (+2 -1 lines)
Petr Skoda committed 2 files to 'Moodle CVS' - 30/Nov/08 01:33 AM
MDL-17372 new course reports string - role definition improvement; merged from MOODLE_19_STABLE
MODIFY lib/accesslib.php   Rev. 1.552    (+2 -2 lines)
MODIFY lang/en_utf8/moodle.php   Rev. 1.213    (+2 -1 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 30/Nov/08 01:43 AM
MDL-17372 new course reports string - role definition improvement; merged from MOODLE_19_STABLE; fixed merging
MODIFY lang/en_utf8/moodle.php   Rev. 1.214    (+2 -2 lines)
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 30/Nov/08 02:13 AM
MDL-17463 Translated a new string for progress reports.
MDL-17372 Translated a new string for course reports.
MDL-17465 Translated new stirngs for live logs.
MODIFY ja_utf8/moodle.php   Rev. 1.331    (+2 -1 lines)
MODIFY ja_utf8/coursereport_log.php   Rev. 1.2    (+2 -0 lines)
ADD ja_utf8/coursereport_progress.php   Rev. 1.1    (+0 -0 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 30/Nov/08 11:09 PM
MDL-17372 moving the categories out of the if cap block - cap report needs to add page there
MODIFY admin/settings/users.php   Rev. 1.41    (+5 -5 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 30/Nov/08 11:20 PM
MDL-17372 moving the categories out of the if cap block - cap report needs to add page there; backported from HEAD
MODIFY admin/settings/users.php   Rev. 1.26.2.11    (+5 -5 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 07/Dec/08 05:41 AM
MDL-17372 fixed regression in 3rd party admin reports
MODIFY admin/settings/plugins.php   Rev. 1.1.2.8    (+3 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 07/Dec/08 05:43 AM
MDL-17372 fixed regression in 3rd party admin reports; merged from MOODLE_19_STABLE
MODIFY admin/settings/plugins.php   Rev. 1.34    (+3 -2 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 07/Dec/08 05:44 AM
fixed regression in 3rd party report - reported by Eloy thanks

martignoni committed 1 file to 'Lang CVS' - 07/Dec/08 11:44 PM
MDL-17372 New lang file added
ADD fr_utf8/report_unittest.php   Rev. 1.1    (+0 -0 lines)
martignoni committed 1 file to 'Lang CVS' - 08/Dec/08 12:06 AM
MDL-17372 new course reports string translated
MODIFY fr_utf8/moodle.php   Rev. 1.261    (+2 -1 lines)
tjhunt committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 04/Feb/09 11:15 AM
admin reports: MDL-18134 Third-party admin reports not listed with the correct name.

Regression caused by MDL-17372.
MODIFY admin/settings/plugins.php   Rev. 1.1.2.9    (+3 -2 lines)
tjhunt committed 1 file to 'Moodle CVS' - 04/Feb/09 11:15 AM
admin reports: MDL-18134 Third-party admin reports not listed with the correct name.

Regression caused by MDL-17372.
MODIFY admin/settings/plugins.php   Rev. 1.36    (+3 -2 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators