|
[
Permalink
| « Hide
]
Petr Skoda added a comment - 26/Nov/08 07:10 AM
eh, just noticed that too - seems to work fine in 1.9.x
Portfolio not in 1.9 and including call to formslib?
Presumably its broken by the pear include_path 'hack' not being setup at that point What Dan said: work's fine if the ini_set trick is done in the formslib.php, as it used to. Maybe it should be done in the beginning of install.php, as config.php is not present to call the setup.php yet?
The environment check is calling the function data_check_required_entries_fields(), for this function it includes the /mod/data/lib.php. This file has require_once('portfoliolib.php') is outside the called function, maybe it's not even needed by the install.php, but just included "in case"?
hmm, module specific code does not belong into environment.xml, 3rd party modules can not do this, there is no reason why official mods should be allowed to do it - going to rewrite the this part
 Hi Petr,
in mod/data/db/upgrade.php if there is not flag, we don't need to unset it: if (!get_config('data', 'requiredentriesfixflag')) { You probably wanted to unset it if there is one... hmm, yes - will have a look at it again today
I reopened this issue in order to remind you, Petr. I just fixed the
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Resolved
Critical
Installer broken by call to formslib
 |
|
All content on this web site is made available under the GNU General Public License, unless otherwise stated.
