Issue Details (XML | Word | Printable)

Key: MDL-17405
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Petr Skoda
Reporter: Dan Poltawski
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Installer broken by call to formslib

Created: 26/Nov/08 06:08 AM   Updated: 08/Jan/09 05:43 PM
Return to search
Component/s: Installation
Affects Version/s: 2.0
Fix Version/s: 2.0

Issue Links:
Duplicate
 
Relates

Participants: Dan Poltawski, Jerome Mouneyrac, Petr Skoda and Samuli Karevaara
Security Level: None
Resolved date: 08/Jan/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
When the web installer gets to the environmental checks it dies on call to formslib.. did a debgging('foo') to get the backtrace ;)

foo
line 24 of lib/formslib.php: call to debugging()
line 30 of lib/portfolio/forms.php: call to require_once()
line 35 of lib/portfoliolib.php: call to require_once()
line 2579 of mod/data/lib.php: call to require_once()
line 555 of lib/environmentlib.php: call to include_once()
line 452 of lib/environmentlib.php: call to environment_custom_checks()
line 86 of lib/environmentlib.php: call to environment_check()
line 802 of install.php: call to check_moodle_environment()
line 610 of install.php: call to form_table()

Warning: require_once(HTML/QuickForm.php) [function.require-once]: failed to open stream: No such file or directory in /srv/moodledev/moodle/lib/formslib.php on line 27

Fatal error: require_once() [function.require]: Failed opening required 'HTML/QuickForm.php' (include_path='.:/usr/share/php:/usr/share/pear') in /srv/moodledev/moodle/lib/formslib.php on line 27

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Petr Skoda added a comment - 26/Nov/08 07:10 AM
eh, just noticed that too - seems to work fine in 1.9.x

[ Permalink | « Hide ]
Dan Poltawski added a comment - 26/Nov/08 07:22 AM
Portfolio not in 1.9 and including call to formslib?

Presumably its broken by the pear include_path 'hack' not being setup at that point


[ Permalink | « Hide ]
Samuli Karevaara added a comment - 27/Nov/08 03:37 PM
What Dan said: work's fine if the ini_set trick is done in the formslib.php, as it used to. Maybe it should be done in the beginning of install.php, as config.php is not present to call the setup.php yet?

[ Permalink | « Hide ]
Samuli Karevaara added a comment - 27/Nov/08 03:43 PM
The environment check is calling the function data_check_required_entries_fields(), for this function it includes the /mod/data/lib.php. This file has require_once('portfoliolib.php') is outside the called function, maybe it's not even needed by the install.php, but just included "in case"?

Samuli Karevaara made changes - 28/Nov/08 04:08 AM
Field Original Value New Value
Link This issue is duplicated by MDL-17419 [ MDL-17419 ]
Petr Skoda made changes - 28/Nov/08 04:17 AM
Assignee moodle.com [ moodle.com ] Petr ?koda [ skodak ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 28/Nov/08 04:23 AM
hmm, module specific code does not belong into environment.xml, 3rd party modules can not do this, there is no reason why official mods should be allowed to do it - going to rewrite the this part

Petr Skoda made changes - 28/Nov/08 07:11 AM
Link This issue has a non-specific relationship to MDL-17427 [ MDL-17427 ]
Petr Skoda committed 4 files to 'Moodle CVS' - 28/Nov/08 07:14 AM
MDL-17405 moving Data mod upgrade notification to proper place (upgrade.php) - better notification will be implemented in MDL-17427
MODIFY mod/data/version.php   Rev. 1.41    (+2 -2 lines)
MODIFY mod/data/lib.php   Rev. 1.210    (+1 -37 lines)
MODIFY admin/environment.xml   Rev. 1.39    (+0 -2 lines)
MODIFY mod/data/db/upgrade.php   Rev. 1.24    (+22 -1 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 28/Nov/08 07:14 AM
should be fixed now....

Petr Skoda made changes - 28/Nov/08 07:14 AM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Samuli Karevaara made changes - 28/Nov/08 10:25 AM
Link This issue has been marked as being related by MDL-17428 [ MDL-17428 ]
[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 02/Dec/08 03:44 PM
Hi Petr,
in mod/data/db/upgrade.php if there is not flag, we don't need to unset it:

if (!get_config('data', 'requiredentriesfixflag')) {
unset_config('requiredentriesfixflag', 'data');
...

You probably wanted to unset it if there is one...


[ Permalink | « Hide ]
Petr Skoda added a comment - 02/Dec/08 05:07 PM
hmm, yes - will have a look at it again today

[ Permalink | « Hide ]
Jerome Mouneyrac added a comment - 08/Jan/09 10:18 AM
I reopened this issue in order to remind you, Petr. I just fixed the MDL-16999. Thanks.

Jerome Mouneyrac made changes - 08/Jan/09 10:18 AM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Petr Skoda committed 1 file to 'Moodle CVS' - 08/Jan/09 05:43 PM
MDL-17405 moved unsetting of old flag to correct place, thanks Jerome
MODIFY mod/data/db/upgrade.php   Rev. 1.25    (+2 -2 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 08/Jan/09 05:43 PM
flag unsetting moved, thanks

Petr Skoda made changes - 08/Jan/09 05:43 PM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators