Moodle

Fix things for internationalization

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Language, Quiz
  • Labels:
    None

Description

Remove "..." and ":" from source code, move to localization strings

Add RTL-specific CSS to rtl.css

Change all currently concatenated lang strings to use $a.

  • change $string['questionsperpageselected'], $string['shufflequestionsselected'] to use $a for quiz settings

http://moodle.org/mod/forum/discuss.php?d=111241

Issue Links

This issue has been marked as being related by:
MDL-12192 Move colon signs form source code into language packs Minor Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olli Savolainen added a comment -

Don't know how to fix this:
print_heading($pagetitle.": ".$quizname, 'left', 2);

See MDL-12192

Show
Olli Savolainen added a comment - Don't know how to fix this: print_heading($pagetitle.": ".$quizname, 'left', 2); See MDL-12192
Hide
Permalink
Olli Savolainen added a comment - - edited

$string['withselected'] = 'With selected';

A new string should be made 'With selected:' but I am not sure if it makes sense to name it 'withselectedcolon' or what so not changing this now.

Used in quiz edit statusbar with a colon, this applies also to 'maximumgrade', 'questions','updatethis', "shufflequestions", 'questionsperpage'

Show
Olli Savolainen added a comment - - edited $string['withselected'] = 'With selected'; A new string should be made 'With selected:' but I am not sure if it makes sense to name it 'withselectedcolon' or what so not changing this now. Used in quiz edit statusbar with a colon, this applies also to 'maximumgrade', 'questions','updatethis', "shufflequestions", 'questionsperpage'
Hide
Permalink
Tim Hunt added a comment -

Actually, for With selected [Choose ...], I think it is perfectly grammatical English to just remove the colon.

For a string like

Maximum grade: 100

I would create a string like

$string['maximumgradex'] = 'Maximum grade: $a';

Recently I have been using x for a placeholder in new language strings I created. No one has complained yet.

Show
Tim Hunt added a comment - Actually, for With selected [Choose ...], I think it is perfectly grammatical English to just remove the colon. For a string like Maximum grade: 100 I would create a string like $string['maximumgradex'] = 'Maximum grade: $a'; Recently I have been using x for a placeholder in new language strings I created. No one has complained yet.
Hide
Permalink
Olli Savolainen added a comment -

It may be grammatical, but it sure is clearer with the already quite strange UI expression to keep the colon.

Show
Olli Savolainen added a comment - It may be grammatical, but it sure is clearer with the already quite strange UI expression to keep the colon.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.