Moodle

Pimp security advisories in the message next to the "Please register tho remove this button"

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.6.8, 1.7.6, 1.8.7, 1.9.3
  • Fix Version/s: 1.9.10
  • Component/s: Administration
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

At the moment, the only benefit that users can see for registering their site is to get rid of the annoying button.

We should instead talk about the most important reason why you'd want (as a site admin) to register your site:

To sign-up on the Security Advisories mailing list

So I suggest we rephrase this sentence:

Please register your site to remove this button

to be something like:

Please register your site to remove this button and <b>receive advance notifications of security updates</b>

Francois

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dougiamas added a comment -

I was planning this should actually be a top-level link in the admin menu at the top right under the "Notifications" item: Registration

Once you register, the link goes away from there for 6 months (could still appear somewhere else deeper of course).

Then we can do away with the interstitial text/button altogether.

How does that sound?

Show
Martin Dougiamas added a comment - I was planning this should actually be a top-level link in the admin menu at the top right under the "Notifications" item: Registration Once you register, the link goes away from there for 6 months (could still appear somewhere else deeper of course). Then we can do away with the interstitial text/button altogether. How does that sound?
Hide
Permalink
Tim Hunt added a comment -

Or:

To receive advance notice of security updates, and to help our usage statistics, please register your site
[Register now]

It is actually a lie that the button will disappear when you click it. The code currently looks like this:

print_box_start('generalbox adminwarning');
if(!isset($CFG->registered)) { print_string('pleaseregister', 'admin'); }
else { /* if (isset($CFG->registered) && $CFG->registered < (time() - 3600*24*30*6)) { */ print_string('pleaserefreshregistration', 'admin', userdate($CFG->registered)); }
print_single_button('register.php', $options, get_string('registration'));
print_box_end();

So I suggest the after registration strings:

This site was registered on dd mmm yyyy. You are subscribed to the security advisory email list using xxx@example.com.
[Update registration details]

or:
This site was registered on dd mmm yyyy. You chose not to subscribe to the security advisory email list.
[Update registration details]

If you are working on this code, these might be good config variables to move to config_plugins.

Show
Tim Hunt added a comment - Or: To receive advance notice of security updates, and to help our usage statistics, please register your site [Register now] It is actually a lie that the button will disappear when you click it. The code currently looks like this: print_box_start('generalbox adminwarning'); if(!isset($CFG->registered)) { print_string('pleaseregister', 'admin'); } else { /* if (isset($CFG->registered) && $CFG->registered < (time() - 3600*24*30*6)) { */ print_string('pleaserefreshregistration', 'admin', userdate($CFG->registered)); } print_single_button('register.php', $options, get_string('registration')); print_box_end(); So I suggest the after registration strings: This site was registered on dd mmm yyyy. You are subscribed to the security advisory email list using xxx@example.com. [Update registration details] or: This site was registered on dd mmm yyyy. You chose not to subscribe to the security advisory email list. [Update registration details] If you are working on this code, these might be good config variables to move to config_plugins.
Hide
Permalink
Francois Marier added a comment -

I see 3 reasons why people may not want to register:

1- privacy/confidentiality (they may not be allowed to report their choice of software)
2- they haven't noticed the registration link/button
3- they don't see the point in doing that

We can't really do anything about #1.

My suggestion was about improving #3 by naming a good reason to register.

I suppose that your plan of moving the block to a top-level link is designed to address #2. I like the 6-month recurrence for the link, but I wonder: will admins actually notice the registration request if it's a tiny link as opposed to a large button in a block?

Show
Francois Marier added a comment - I see 3 reasons why people may not want to register: 1- privacy/confidentiality (they may not be allowed to report their choice of software) 2- they haven't noticed the registration link/button 3- they don't see the point in doing that We can't really do anything about #1. My suggestion was about improving #3 by naming a good reason to register. I suppose that your plan of moving the block to a top-level link is designed to address #2. I like the 6-month recurrence for the link, but I wonder: will admins actually notice the registration request if it's a tiny link as opposed to a large button in a block?
Hide
Permalink
Martin Dougiamas added a comment - - edited

I attached mock screenshot as an example of how the registration link could look ... I think that would be obvious enough. We can reword the actual registration page to make it clearer too..

Show
Martin Dougiamas added a comment - - edited I attached mock screenshot as an example of how the registration link could look ... I think that would be obvious enough. We can reword the actual registration page to make it clearer too..
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Assigning to Martin...

Personally I like the idea of the register link in admin menu (after 6 months). Perhaps it could be "Register / Update register".

Anyway, the part I'm more critical is the message in the notifications page, that is "bigger" (hence, distracts more) when you've registered that when you haven't.

Perhaps also the "register/update register" differentiation must be in that button in the notifications page.

Apart of all, yup, agree about the need to be some more explanatory in the notifications page, as comented and agreeded by all you.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Martin... Personally I like the idea of the register link in admin menu (after 6 months). Perhaps it could be "Register / Update register". Anyway, the part I'm more critical is the message in the notifications page, that is "bigger" (hence, distracts more) when you've registered that when you haven't. Perhaps also the "register/update register" differentiation must be in that button in the notifications page. Apart of all, yup, agree about the need to be some more explanatory in the notifications page, as comented and agreeded by all you. Ciao
Hide
Permalink
Martin Dougiamas added a comment -

Well, I think we can take it away from the notifications page entirely once it's a menu item (a copy can live under "Server" as well, so that it can be reached any time)

Show
Martin Dougiamas added a comment - Well, I think we can take it away from the notifications page entirely once it's a menu item (a copy can live under "Server" as well, so that it can be reached any time)
Hide
Permalink
Martin Dougiamas added a comment -

I've moved the notifications to the menus (been meaning to do this for ages anyway).

The registration page needs a big revamp for the course-publishing and hub stuff in Moodle 2.0. It'll involve making that page a proper mform, and adding new sections for courses, metadata, etc ... as well as lots of rewording. I'll leave that to another bug.

Show
Martin Dougiamas added a comment - I've moved the notifications to the menus (been meaning to do this for ages anyway). The registration page needs a big revamp for the course-publishing and hub stuff in Moodle 2.0. It'll involve making that page a proper mform, and adding new sections for courses, metadata, etc ... as well as lots of rewording. I'll leave that to another bug.
Hide
Permalink
Martin Dougiamas added a comment -

I'll reopen this bug because the original suggestions could still be fixed in older versions.

Show
Martin Dougiamas added a comment - I'll reopen this bug because the original suggestions could still be fixed in older versions.
Hide
Permalink
Francois Marier added a comment -

I think we can just close this one, the new registration code is quite good.

Show
Francois Marier added a comment - I think we can just close this one, the new registration code is quite good.

People

Vote (2)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.