Issue Details (XML | Word | Printable)

Key: MDL-17429
Type: Improvement Improvement
Status: Reopened Reopened
Priority: Minor Minor
Assignee: Martin Dougiamas
Reporter: Francois Marier
Votes: 2
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Pimp security advisories in the message next to the "Please register tho remove this button"

Created: 28/Nov/08 09:48 AM   Updated: 21/Oct/09 04:17 PM
Return to search
Component/s: Administration
Affects Version/s: 1.6.8, 1.7.6, 1.8.7, 1.9.3
Fix Version/s: 1.9.7

File Attachments: None
Image Attachments:

1. example registration.jpg
(208 kB)

Participants: Eloy Lafuente (stronk7), Francois Marier, Martin Dougiamas and Tim Hunt
Security Level: None
Difficulty: Easy
Resolved date: 10/Dec/08
Affected Branches: MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
At the moment, the only benefit that users can see for registering their site is to get rid of the annoying button.

We should instead talk about the most important reason why you'd want (as a site admin) to register your site:

  To sign-up on the Security Advisories mailing list

So I suggest we rephrase this sentence:

  Please register your site to remove this button

to be something like:

  Please register your site to remove this button and <b>receive advance notifications of security updates</b>

Francois

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Martin Dougiamas added a comment - 04/Dec/08 10:25 AM
I was planning this should actually be a top-level link in the admin menu at the top right under the "Notifications" item: Registration

Once you register, the link goes away from there for 6 months (could still appear somewhere else deeper of course).

Then we can do away with the interstitial text/button altogether.

How does that sound?


Tim Hunt added a comment - 04/Dec/08 10:37 AM
Or:

To receive advance notice of security updates, and to help our usage statistics, please register your site
[Register now]

It is actually a lie that the button will disappear when you click it. The code currently looks like this:

print_box_start('generalbox adminwarning');
if(!isset($CFG->registered)) { print_string('pleaseregister', 'admin'); }
else { /* if (isset($CFG->registered) && $CFG->registered < (time() - 3600*24*30*6)) { */ print_string('pleaserefreshregistration', 'admin', userdate($CFG->registered)); }
print_single_button('register.php', $options, get_string('registration'));
print_box_end();

So I suggest the after registration strings:

This site was registered on dd mmm yyyy. You are subscribed to the security advisory email list using xxx@example.com.
[Update registration details]

or:
This site was registered on dd mmm yyyy. You chose not to subscribe to the security advisory email list.
[Update registration details]

If you are working on this code, these might be good config variables to move to config_plugins.


Francois Marier added a comment - 04/Dec/08 10:37 AM
I see 3 reasons why people may not want to register:

1- privacy/confidentiality (they may not be allowed to report their choice of software)
2- they haven't noticed the registration link/button
3- they don't see the point in doing that

We can't really do anything about #1.

My suggestion was about improving #3 by naming a good reason to register.

I suppose that your plan of moving the block to a top-level link is designed to address #2. I like the 6-month recurrence for the link, but I wonder: will admins actually notice the registration request if it's a tiny link as opposed to a large button in a block?


Martin Dougiamas added a comment - 04/Dec/08 04:50 PM - edited
I attached mock screenshot as an example of how the registration link could look ... I think that would be obvious enough. We can reword the actual registration page to make it clearer too..

Martin Dougiamas made changes - 04/Dec/08 04:50 PM
Field Original Value New Value
Attachment example registration.jpg [ 15802 ]
Eloy Lafuente (stronk7) made changes - 10/Dec/08 04:01 AM
Assignee moodle.com [ moodle.com ] Martin Dougiamas [ dougiamas ]
Eloy Lafuente (stronk7) added a comment - 10/Dec/08 04:01 AM
Assigning to Martin...

Personally I like the idea of the register link in admin menu (after 6 months). Perhaps it could be "Register / Update register".

Anyway, the part I'm more critical is the message in the notifications page, that is "bigger" (hence, distracts more) when you've registered that when you haven't.

Perhaps also the "register/update register" differentiation must be in that button in the notifications page.

Apart of all, yup, agree about the need to be some more explanatory in the notifications page, as comented and agreeded by all you.

Ciao


Martin Dougiamas added a comment - 10/Dec/08 02:07 PM
Well, I think we can take it away from the notifications page entirely once it's a menu item (a copy can live under "Server" as well, so that it can be reached any time)

moodler committed 5 files to 'Moodle CVS' - 10/Dec/08 03:23 PM
admin MDL-17429 Move registration button to admin menu, and make registration page a proper admin page, also fix bad DML call
admin MDL-16867 Change "Optional subsystems" menu item to "Advanced features"

(Sorry for the mixed checkin)
MODIFY lang/en_utf8/admin.php   Rev. 1.246    (+2 -1 lines)
MODIFY admin/settings/server.php   Rev. 1.56    (+3 -1 lines)
MODIFY admin/register.php   Rev. 1.31    (+11 -11 lines)
MODIFY admin/index.php   Rev. 1.344    (+1 -15 lines)
MODIFY admin/settings/top.php   Rev. 1.28    (+7 -2 lines)
Martin Dougiamas added a comment - 10/Dec/08 03:28 PM
I've moved the notifications to the menus (been meaning to do this for ages anyway).

The registration page needs a big revamp for the course-publishing and hub stuff in Moodle 2.0. It'll involve making that page a proper mform, and adding new sections for courses, metadata, etc ... as well as lots of rewording. I'll leave that to another bug.


Martin Dougiamas made changes - 10/Dec/08 03:28 PM
Fix Version/s 2.0 [ 10122 ]
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Martin Dougiamas added a comment - 10/Dec/08 03:29 PM
I'll reopen this bug because the original suggestions could still be fixed in older versions.

Martin Dougiamas made changes - 10/Dec/08 03:29 PM
Fix Version/s 1.6.9 [ 10316 ]
Fix Version/s 1.7.7 [ 10315 ]
Resolution Fixed [ 1 ]
Fix Version/s 1.9.4 [ 10300 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Fix Version/s 1.8.8 [ 10314 ]
Fix Version/s 2.0 [ 10122 ]
martignoni committed 1 file to 'Lang CVS' - 10/Dec/08 07:41 PM
MDL-17429, MDL-16867, strings translated
MODIFY fr_utf8/admin.php   Rev. 1.323    (+3 -2 lines)
Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 11/Dec/08 01:36 PM
MDL-17429 MDL-16867 Translated new strings fro admin.
MDL-16583 Translated a new string for the close_window function.
MDL-17575 Translated a new string for role.
MODIFY ja_utf8/admin.php   Rev. 1.323    (+8 -2 lines)
MODIFY ja_utf8/role.php   Rev. 1.85    (+2 -1 lines)
MODIFY ja_utf8/moodle.php   Rev. 1.338    (+3 -2 lines)
MODIFY ja_utf8/README   Rev. 1.889    (+1 -1 lines)
Petr Skoda made changes - 22/Jan/09 03:05 AM
Fix Version/s 1.8.9 [ 10322 ]
Fix Version/s 1.9.4 [ 10300 ]
Fix Version/s 1.8.8 [ 10314 ]
Fix Version/s 1.9.5 [ 10320 ]
Martin Dougiamas made changes - 28/Jan/09 06:11 PM
Fix Version/s 1.7.8 [ 10324 ]
Fix Version/s 1.7.7 [ 10315 ]
Martin Dougiamas made changes - 28/Jan/09 10:40 PM
Fix Version/s 1.7.8 [ 10324 ]
Fix Version/s 1.6.9 [ 10316 ]
Petr Skoda made changes - 06/May/09 05:42 PM
Fix Version/s 1.8.9 [ 10322 ]
Fix Version/s 1.9.6 [ 10340 ]
Fix Version/s 1.9.5 [ 10320 ]
Martin Dougiamas made changes - 21/Oct/09 04:17 PM
Fix Version/s 1.9.7 [ 10360 ]
Fix Version/s 1.9.6 [ 10340 ]