Issue Details (XML | Word | Printable)

Key: MDL-17448
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Dongsheng Cai
Reporter: Chris Fryer
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Internet Explorer hangs when editing Wiki in enlarged editor (fullscreen)

Created: 28/Nov/08 11:02 PM   Updated: 23/Oct/09 08:36 AM
Component/s: Wiki (1.x)
Affects Version/s: 1.9, 1.9.1, 1.9.2
Fix Version/s: 1.9.4

File Attachments: 1. Text File fullscreen.patch (0.6 kB)
2. Text File fullscreen_new.patch (0.7 kB)

Environment: Internet Explorer 6 or 7
Issue Links:
Duplicate
 

Participants: Chris Fryer, Dongsheng Cai, Eloy Lafuente (stronk7) and Petr Škoda (skodak)
Security Level: None
QA Assignee: Petr Škoda (skodak)
Resolved date: 04/Dec/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
When editing a wiki (1.x) using Internet Explorer, if you click "Enlarge Editor", a new window opens but hangs on loading. See this discussion:

http://moodle.org/mod/forum/discuss.php?d=100728

Steps to reproduce:

1. Using Internet Explorer, add a "Wiki" resource, and fill out the form
2. Click "Save and display"
3. Click the "Enlarge Editor" icon

Expected result:

The HTMLArea editor should open in a new window

Actual result:

A new window opens, but never finishes loading. iexplore.exe must be killed.

As the discussion indicates, there appears to be something wrong with /yui/event/event-min.js. The problem does not occur in Moodle 1.8, so it appears to be a regression in Moodle 1.9. The attached patch implements a workaround, which prevents the "event" library from loading in the HTMLArea.

I imagine this will be a pig to fix, as the YUI library is fairly involved.

Tagged "Major" as it causes a browser crash.



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Chris Fryer added a comment - 28/Nov/08 11:07 PM
Typos all over the place.

Eloy Lafuente (stronk7) added a comment - 01/Dec/08 08:30 AM
Assigning to Dongsheng... because Mathieu isn't here... could you, plz take a look to this?

Dongsheng Cai added a comment - 04/Dec/08 05:26 PM
Thanks, chris, your patch has been committed.

Chris Fryer added a comment - 04/Dec/08 07:42 PM
The patch I submitted earlier has a flaw in the logic. The "bitwise and" statement will only load YUI scripts in Internet Explorer. Sorry.

Here's another patch that only skips loading the event library when you are using Internet Explorer, which was the original intention.

At any rate, this does not fix the bug: it only avoids it. I presume this is just triage ahead of the introduction of nwiki in 2.0


Chris Fryer added a comment - 04/Dec/08 08:04 PM
P.S. Credit for this patch should really go to Kris Thornley, who identified the problematic script:

http://moodle.org/mod/forum/discuss.php?d=100728#p454658


Petr Škoda (skodak) added a comment - 09/Dec/08 10:26 PM
tested, thanks!