Moodle

Internet Explorer hangs when editing Wiki in enlarged editor (fullscreen)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9, 1.9.1, 1.9.2
  • Fix Version/s: 1.9.4
  • Component/s: Wiki (1.x)
  • Labels:
    None
  • Environment:
    Internet Explorer 6 or 7
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

When editing a wiki (1.x) using Internet Explorer, if you click "Enlarge Editor", a new window opens but hangs on loading. See this discussion:

http://moodle.org/mod/forum/discuss.php?d=100728

Steps to reproduce:

1. Using Internet Explorer, add a "Wiki" resource, and fill out the form
2. Click "Save and display"
3. Click the "Enlarge Editor" icon

Expected result:

The HTMLArea editor should open in a new window

Actual result:

A new window opens, but never finishes loading. iexplore.exe must be killed.

As the discussion indicates, there appears to be something wrong with /yui/event/event-min.js. The problem does not occur in Moodle 1.8, so it appears to be a regression in Moodle 1.9. The attached patch implements a workaround, which prevents the "event" library from loading in the HTMLArea.

I imagine this will be a pig to fix, as the YUI library is fairly involved.

Tagged "Major" as it causes a browser crash.

Attachments

  1. Text File
    fullscreen_new.patch
    04/Dec/08 7:42 PM
    0.7 kB
    Chris Fryer
  2. Text File
    fullscreen.patch
    28/Nov/08 11:02 PM
    0.6 kB
    Chris Fryer

Issue Links

This issue is duplicated by:
MDL-2706 [wiki] Using the HTML editor within Wiki (moodle v1.4.3) on Firefox (v1.0.1) creates a violent flicker. Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Fryer added a comment -

Typos all over the place.

Show
Chris Fryer added a comment - Typos all over the place.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Assigning to Dongsheng... because Mathieu isn't here... could you, plz take a look to this?

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Dongsheng... because Mathieu isn't here... could you, plz take a look to this?
Hide
Permalink
Dongsheng Cai added a comment -

Thanks, chris, your patch has been committed.

Show
Dongsheng Cai added a comment - Thanks, chris, your patch has been committed.
Hide
Permalink
Chris Fryer added a comment -

The patch I submitted earlier has a flaw in the logic. The "bitwise and" statement will only load YUI scripts in Internet Explorer. Sorry.

Here's another patch that only skips loading the event library when you are using Internet Explorer, which was the original intention.

At any rate, this does not fix the bug: it only avoids it. I presume this is just triage ahead of the introduction of nwiki in 2.0

Show
Chris Fryer added a comment - The patch I submitted earlier has a flaw in the logic. The "bitwise and" statement will only load YUI scripts in Internet Explorer. Sorry. Here's another patch that only skips loading the event library when you are using Internet Explorer, which was the original intention. At any rate, this does not fix the bug: it only avoids it. I presume this is just triage ahead of the introduction of nwiki in 2.0
Hide
Permalink
Chris Fryer added a comment -

P.S. Credit for this patch should really go to Kris Thornley, who identified the problematic script:

http://moodle.org/mod/forum/discuss.php?d=100728#p454658

Show
Chris Fryer added a comment - P.S. Credit for this patch should really go to Kris Thornley, who identified the problematic script: http://moodle.org/mod/forum/discuss.php?d=100728#p454658
Hide
Permalink
Petr Škoda (skodak) added a comment -

tested, thanks!

Show
Petr Škoda (skodak) added a comment - tested, thanks!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.