Issue Details (XML | Word | Printable)

Key: MDL-17455
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: Olli Savolainen
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-17284

Refactor quiz_question_action_icons

Created: 29/Nov/08 01:53 AM   Updated: 11/Feb/09 07:09 PM
Return to search
Component/s: Quiz
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Olli Savolainen and Tim Hunt
Security Level: None
Difficulty: Moderate
Resolved date: 11/Feb/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
quiz_question_action_icons is not used by the edit tab nor the ordering/paging tab, since the logic has changed. Is there use for this function still, and should it be refactored at least for the ordering tab - extending it for the edit tab it may pointless since everything is displayed so differently there.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
tjhunt committed 3 files to 'Moodle CVS' - 11/Feb/09 07:08 PM
quiz editing: MDL-17455 refactor the editing code to use the locallib functions to print the icons.

Also, use the new method in the random question class to get the list of random questions reliably.
MODIFY question/editlib.php   Rev. 1.111    (+4 -4 lines)
MODIFY mod/quiz/locallib.php   Rev. 1.173    (+60 -27 lines)
MODIFY mod/quiz/editlib.php   Rev. 1.109    (+98 -210 lines)
tjhunt committed 1 file to 'Moodle CVS' - 11/Feb/09 07:35 PM
quiz editing: MDL-17455 fix missing global. Oops.
MODIFY mod/quiz/editlib.php   Rev. 1.110    (+2 -2 lines)
tjhunt committed 1 file to 'Moodle CVS' - 12/Feb/09 02:04 PM
quiz editing: MDL-17455 fix non-unique first column in get records. Thanks Olli for spotting this.
MODIFY mod/quiz/editlib.php   Rev. 1.111    (+2 -2 lines)