Issue Details (XML | Word | Printable)

Key: MDL-17457
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-17458

replace statements in install.xml and post install hooks with install.php in db directories for all plugins

Created: 29/Nov/08 02:58 AM   Updated: 10/Mar/09 05:16 PM
Return to search
Component/s: Installation
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Dongsheng Cai, Martin Dougiamas, Penny Leach and Petr Skoda
Security Level: None
Resolved date: 16/Jan/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Current install is not nice, it must be fully separated from UI in admin/index.php, we have to remove tons of ifs used for cli and unittests, there many other long standing problems too...

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Penny Leach added a comment - 19/Dec/08 09:00 PM
please make sure there's post install hooks for local/ too

Petr Skoda added a comment - 11/Jan/09 02:04 AM - edited
the main install.php should install:
1/ main site course
2/ guest account
3/ mnet default site record
4/ logs setup

Petr Skoda added a comment - 16/Jan/09 07:24 AM
done

Petr Skoda added a comment - 16/Jan/09 07:24 AM
oops, reopening, forgot local install.php

Petr Skoda added a comment - 16/Jan/09 10:58 PM
reclosing, implemented in locallib too

Martin Dougiamas added a comment - 10/Mar/09 10:50 AM
This one caught me out a bit, because we'd earlier added support in 1.9 and 2.0 for an $pluginname_install() function in lib.php of all plugins.

I note this hook is now deleted from 2.0 code, so this may bite anyone currently using this hook for 3rd party modules in 1.9. We should mention this in the release notes at least.

I do prefer the install.php method, though I don't know why the function name starts with xmldb_ since it's not related to xmldb at all ..


Dongsheng Cai added a comment - 10/Mar/09 11:11 AM
Fixed message/out installation code for this issue

Petr Skoda added a comment - 10/Mar/09 05:16 PM
There is a new readme file in mod/ blocks/ etc that explains what should be done in order to update plugin code for 2.0,
I used that name because upgrade.php uses something similar, any better name for that function?