[#MDL-17485] review use of moodle/user:viewuseractivitiesreport and add risk

Issue Details (XML | Word | Printable)

Key:	MDL-17485
Type:	Sub-task
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-17205

review use of moodle/user:viewuseractivitiesreport and add risk

Created: 02/Dec/08 04:05 AM Updated: 09/Dec/08 04:59 PM

Return to search

Component/s:

Roles

Affects Version/s:

1.9

Fix Version/s:

1.9.4

Participants:	Petr Skoda and Tim Hunt
Security Level:	None
QA Assignee:	Tim Hunt
Resolved date:	02/Dec/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

1/ it is used incorrectly in course context
2/ it does not make sense to set it for any legacy role - intended for parents only
3/ missing RISK_PERSONAL

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 5 files to 'Moodle CVS' - 02/Dec/08 04:19 AM

~~MDL-17485~~ roles: fixed use and definition of review use of moodle/user:viewuseractivitiesreport

MODIFY	user/tabs.php	Rev. 1.74	(+5 -1 lines)
MODIFY	lib/db/access.php	Rev. 1.95	(+3 -4 lines)
MODIFY	version.php	Rev. 1.903	(+1 -1 lines)
MODIFY	course/user.php	Rev. 1.92	(+5 -1 lines)
MODIFY	lib/weblib.php	Rev. 1.1180	(+6 -5 lines)

Petr Skoda committed 5 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/Dec/08 04:20 AM

~~MDL-17485~~ roles: fixed use and definition of moodle/user:viewuseractivitiesreport; backported from HEAD

MODIFY	course/user.php	Rev. 1.75.2.12	(+5 -1 lines)
MODIFY	user/tabs.php	Rev. 1.43.2.7	(+5 -1 lines)
MODIFY	lib/weblib.php	Rev. 1.970.2.119	(+6 -5 lines)
MODIFY	lib/db/access.php	Rev. 1.75.2.14	(+3 -4 lines)
MODIFY	version.php	Rev. 1.563.2.330	(+1 -1 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 02/Dec/08 04:23 AM

fixed in cvs, updated http://docs.moodle.org/en/Capabilities/moodle/user:viewuseractivitiesreport

Petr Skoda made changes - 02/Dec/08 04:23 AM

Field	Original Value	New Value
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Tim Hunt added a comment - 09/Dec/08 03:41 PM

Petr, just for your information, I recently added a function ensure_context_subobj_present to accesslib, which lets you replace code like

if (isset($user->context->id)) {
$usercontext = $user->context;
} else {
$usercontext = get_context_instance(CONTEXT_USER, $user->id);
}

with

ensure_context_subobj_present($user, CONTEXT_USER);
$usercontext = $user->context;

Tim Hunt made changes - 09/Dec/08 03:41 PM

QA Assignee

timhunt

[ Permalink | « Hide ]

Tim Hunt added a comment - 09/Dec/08 04:59 PM

Reviewed code and tested. Looks good to me. Thanks.

Tim Hunt made changes - 09/Dec/08 04:59 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.