[#MDL-17492] Reset Flag (Manage Tags)

Issue Details (XML | Word | Printable)

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Created: 02/Dec/08 09:01 PM Updated: 04/Mar/09 05:30 PM

Component/s:

Tags

Affects Version/s:

1.9.3

Fix Version/s:

1.9.5

Database:	PostgreSQL
Participants:	David Mudrak, Dennis Meyer and Eloy Lafuente (stronk7)
Security Level:	None
QA Assignee:	Eloy Lafuente (stronk7)
Resolved date:	03/Mar/09
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Nothing happens when I choose some flagged tags and try to reset the flags. Moodle shows:
"tag-name" – Reset
But the tag is still flagged :-/

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

The same observed at my site running the latest Moodle 1.9.4+. Assigning to myself - I am going to look at it tommorow.

[ Permalink | « Hide ]

This seems to be PostgreSQL specific bug. Postgres does not seem to support table alias in UPDATE statement. Therefore the SQL like

UPDATE mdl_tag tg SET tg.flag = 0, tg.timemodified = 1236027984 WHERE tg.id IN (4)

ends with an error
ERROR: column "tg" of relation "mdl_tag" does not exist LINE 1: UPDATE mdl_tag tg SET tg.flag = 0, tg.timemodified = 1236027...

The fix is quite easy - just do not use table alias as it makes no sense here anyway

[ Permalink | « Hide ]

Fixed in MOODLE_19_STABLE and merged into HEAD.

[ Permalink | « Hide ]

Verified. Closing. Thanks David! B-)

[ Permalink | « Hide ]

Thanks a lot!

All content on this web site is made available under the GNU General Public License, unless otherwise stated.