Issue Details (XML | Word | Printable)

Key: MDL-17502
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Tim Hunt
Reporter: Tim Hunt
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

When you delete a course category, it does not check that you have permission to delete the courses in it

Created: 03/Dec/08 05:58 PM   Updated: 10/Dec/08 07:39 AM
Return to search
Component/s: Administration
Affects Version/s: 1.9.3
Fix Version/s: 1.9.4

Participants: Petr Skoda and Tim Hunt
Security Level: None
Resolved date: 10/Dec/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Tim Hunt added a comment - 08/Dec/08 02:37 PM
Note: see MDL-17499.

Tim Hunt made changes - 08/Dec/08 04:28 PM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
tjhunt committed 6 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 08/Dec/08 04:28 PM
course categories: MDL-17502 when deleting a category and its contents, check moodle/course:delete capability.

* Note: this would never lead to problems with default role definions.
* Also ended up mostly rewriting delete_category_form to simplify the messages that are displayed.
* New helper function require_all_capabilities, a bit like require_any_capability.
MODIFY course/delete_category_form.php   Rev. 1.1.2.3    (+83 -33 lines)
MODIFY course/index.php   Rev. 1.89.2.8    (+1 -6 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.26.2.18    (+2 -1 lines)
MODIFY lib/accesslib.php   Rev. 1.421.2.86    (+25 -1 lines)
MODIFY lang/en_utf8/moodle.php   Rev. 1.141.2.50    (+7 -1 lines)
MODIFY course/lib.php   Rev. 1.538.2.60    (+5 -4 lines)
tjhunt committed 6 files to 'Moodle CVS' - 08/Dec/08 04:28 PM
course categories: MDL-17502 when deleting a category and its contents, check moodle/course:delete capability.

* Note: this would never lead to problems with default role definions.
* Also ended up mostly rewriting delete_category_form to simplify the messages that are displayed.
* New helper function require_all_capabilities, a bit like require_any_capability.
MODIFY lang/en_utf8/moodle.php   Rev. 1.218    (+7 -1 lines)
MODIFY course/delete_category_form.php   Rev. 1.4    (+84 -34 lines)
MODIFY course/index.php   Rev. 1.104    (+1 -6 lines)
MODIFY lib/accesslib.php   Rev. 1.554    (+25 -1 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.146    (+2 -1 lines)
MODIFY course/lib.php   Rev. 1.625    (+5 -4 lines)
martignoni committed 2 files to 'Lang CVS' - 08/Dec/08 08:20 PM
MDL-17502 strings translated
MODIFY fr_utf8/moodle.php   Rev. 1.265    (+7 -1 lines)
MODIFY fr_utf8/error.php   Rev. 1.151    (+2 -1 lines)
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 09/Dec/08 09:35 AM
MDL-17502 Translated new strings for course categories.
MODIFY ja_utf8/error.php   Rev. 1.107    (+2 -1 lines)
MODIFY ja_utf8/moodle.php   Rev. 1.337    (+7 -1 lines)
MODIFY ja_utf8/README   Rev. 1.888    (+1 -1 lines)
tjhunt committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 09/Dec/08 06:27 PM
course categories: MDL-17502 followup. Fix notices. I'm sure I remember writing this code yesterday!
MODIFY course/lib.php   Rev. 1.538.2.61    (+5 -1 lines)
tjhunt committed 1 file to 'Moodle CVS' - 09/Dec/08 06:27 PM
course categories: MDL-17502 followup. Fix notices. I'm sure I remember writing this code yesterday!
MODIFY course/lib.php   Rev. 1.626    (+5 -1 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 10/Dec/08 12:37 AM
reopening - has_all_capabilities() expects array in capabilities, but string is sent there instead --> warning + incorrect result

working on a fix


Petr Skoda made changes - 10/Dec/08 12:37 AM
Status Resolved [ 5 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 10/Dec/08 01:07 AM
I think I found and fixed that this afternoon. Try a CVS update before you waste too much time!

Petr Skoda committed 2 files to 'Moodle CVS' - 10/Dec/08 01:25 AM
MDL-17502 accesslib: added warning if incorrect parameters supplied to has_all_capabilities() and fixed parameters in course lib code
MODIFY lib/accesslib.php   Rev. 1.555    (+5 -1 lines)
MODIFY course/lib.php   Rev. 1.627    (+9 -5 lines)
Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Dec/08 01:26 AM
MDL-17502 accesslib: added warning if incorrect parameters supplied to has_all_capabilities() and fixed parameters in course lib code; backported from HEAD
MODIFY lib/accesslib.php   Rev. 1.421.2.87    (+5 -1 lines)
MODIFY course/lib.php   Rev. 1.538.2.62    (+9 -5 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 10/Dec/08 01:26 AM
ooops

[ Permalink | « Hide ]
Petr Skoda added a comment - 10/Dec/08 01:33 AM
I have added an array test into accesslib just to make sure if there is a similar problem in future it gets caught immediately,
hmm - I have committed different patch with just one "if" and then noticed your change, next time I will watch the tracker and cvs - sorrrry

Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Dec/08 01:34 AM
MDL-17502 oops, I have overlooked Tim already fixed this - sorry
MODIFY course/lib.php   Rev. 1.538.2.63    (+1 -5 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 10/Dec/08 01:35 AM
MDL-17502 oops, I have overlooked Tim already fixed this - sorry; merged from MOODLE_19_STABLE
MODIFY course/lib.php   Rev. 1.628    (+1 -5 lines)
Petr Skoda made changes - 10/Dec/08 01:37 AM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 10/Dec/08 07:39 AM
Yes, I thought your code looked nicer than mine. Thanks.


Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators