Moodle

When you delete a course category, it does not check that you have permission to delete the courses in it

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Activity

Hide
Tim Hunt added a comment -

Note: see MDL-17499.

Show
Tim Hunt added a comment - Note: see MDL-17499.
Hide
Petr Škoda (skodak) added a comment -

reopening - has_all_capabilities() expects array in capabilities, but string is sent there instead --> warning + incorrect result

working on a fix

Show
Petr Škoda (skodak) added a comment - reopening - has_all_capabilities() expects array in capabilities, but string is sent there instead --> warning + incorrect result working on a fix
Hide
Tim Hunt added a comment -

I think I found and fixed that this afternoon. Try a CVS update before you waste too much time!

Show
Tim Hunt added a comment - I think I found and fixed that this afternoon. Try a CVS update before you waste too much time!
Hide
Petr Škoda (skodak) added a comment -

ooops

Show
Petr Škoda (skodak) added a comment - ooops
Hide
Petr Škoda (skodak) added a comment -

I have added an array test into accesslib just to make sure if there is a similar problem in future it gets caught immediately,
hmm - I have committed different patch with just one "if" and then noticed your change, next time I will watch the tracker and cvs - sorrrry

Show
Petr Škoda (skodak) added a comment - I have added an array test into accesslib just to make sure if there is a similar problem in future it gets caught immediately, hmm - I have committed different patch with just one "if" and then noticed your change, next time I will watch the tracker and cvs - sorrrry
Hide
Tim Hunt added a comment -

Yes, I thought your code looked nicer than mine. Thanks.

Show
Tim Hunt added a comment - Yes, I thought your code looked nicer than mine. Thanks.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: