[#MDL-17502] When you delete a course category, it does not check that you have permission to delete the courses in it

Issue Details (XML | Word | Printable)

Key:	MDL-17502
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Critical
Assignee:	Tim Hunt
Reporter:	Tim Hunt
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

When you delete a course category, it does not check that you have permission to delete the courses in it

Created: 03/Dec/08 05:58 PM Updated: 10/Dec/08 07:39 AM

Component/s:

Administration

Affects Version/s:

1.9.3

Fix Version/s:

1.9.4

Participants:	Petr Skoda and Tim Hunt
Security Level:	None
Resolved date:	10/Dec/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Tim Hunt added a comment - 08/Dec/08 02:37 PM

Note: see MDL-17499.

[ Permalink | « Hide ]

Petr Skoda added a comment - 10/Dec/08 12:37 AM

reopening - has_all_capabilities() expects array in capabilities, but string is sent there instead --> warning + incorrect result

working on a fix

[ Permalink | « Hide ]

Tim Hunt added a comment - 10/Dec/08 01:07 AM

I think I found and fixed that this afternoon. Try a CVS update before you waste too much time!

[ Permalink | « Hide ]

Petr Skoda added a comment - 10/Dec/08 01:26 AM

ooops

[ Permalink | « Hide ]

Petr Skoda added a comment - 10/Dec/08 01:33 AM

I have added an array test into accesslib just to make sure if there is a similar problem in future it gets caught immediately,
hmm - I have committed different patch with just one "if" and then noticed your change, next time I will watch the tracker and cvs - sorrrry

[ Permalink | « Hide ]

Tim Hunt added a comment - 10/Dec/08 07:39 AM

Yes, I thought your code looked nicer than mine. Thanks.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.