Moodle

[Patch] Put the text "detailedmonthview" of the calendar inside a label, so i can grab it on theme

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.8
  • Component/s: Accessibility, Calendar, Themes
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

I am working on a theme for the Federal University of Santa Catarina, in Brazil and the designer ask me to vertical-centralize this text. The better way i found to do this is put the text inside a label, cause it was "flying" inside the div.
The patch for Moodle 1.9.3 and a slice of the screenshot is attached.
Hope you like.

Attachments

  1. File
    mdl17510-195.diff
    18/May/09 8:46 PM
    0.6 kB
    Daniel Neis
  2. File
    mdl-17510-v2.diff
    03/Mar/10 2:10 AM
    8 kB
    Daniel Neis
  3. File
    patch_label.diff
    04/Dec/08 2:04 AM
    0.5 kB
    Daniel Neis
  1. detailedmonthview.png
    120 kB
    27/Nov/09 12:37 AM
  2. screen.png
    35 kB
    04/Dec/08 2:04 AM

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniel Neis added a comment -

the patch and the screenshot i have metioned.
couldn't find them after submit the issue...

Show
Daniel Neis added a comment - the patch and the screenshot i have metioned. couldn't find them after submit the issue...
Hide
Permalink
Daniel Neis added a comment -

the patch for 1.9.5 version

Show
Daniel Neis added a comment - the patch for 1.9.5 version
Hide
Permalink
Daniel Neis added a comment -

posting a screenshot with text in english

Show
Daniel Neis added a comment - posting a screenshot with text in english
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Hi Daniel,

I've been looking at this and, in the detailed month view I'm getting that HTML within one label, exactly as your patch does:

<label for="cal_course_flt_jump">Detailed Month View:</label>

Curiously, looking a bit more in calendar/lib.php, I've seen that there are three places where That label should be present:

  • calendar_show_day() - that is missing the label.
  • calendar_show_month_detailed() - that already has the label, as showed above.
  • calendar_show_upcoming_events() - that is missing the label.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi Daniel, I've been looking at this and, in the detailed month view I'm getting that HTML within one label, exactly as your patch does: 
<label for="cal_course_flt_jump">Detailed Month View:</label>
Curiously, looking a bit more in calendar/lib.php, I've seen that there are three places where That label should be present:
  • calendar_show_day() - that is missing the label.
  • calendar_show_month_detailed() - that already has the label, as showed above.
  • calendar_show_upcoming_events() - that is missing the label.
Ciao
Hide
Permalink
Daniel Neis added a comment -

Hello, Eloy

i think someone else have added the label in another commit (http://cvs.moodle.org/moodle/calendar/view.php?r1=1.95&r2=1.95.2.10) some time ago...
I have a clone of git.moodle.org repo, and did a seach "git log -Scal_course_flt_jump calendar/" and have found the commit:

daniel@judy:~/public_html/moodle$ git show d4d468ad374e344c90eb278092e6e425232b0b66
commit d4d468ad374e344c90eb278092e6e425232b0b66
Author: moodler <moodler>
Date:   Thu Oct 1 07:02:15 2009 +0000

    calendar MDL-19940 Don't require login for site calendar when forcelogin is false

diff --git a/calendar/view.php b/calendar/view.php
index eeedb32..92abf88 100644
--- a/calendar/view.php
+++ b/calendar/view.php
@@ -54,7 +54,7 @@
         redirect($CFG->wwwroot.'/'.$CFG->admin.'/index.php');
     }
 
-    if ($courseid) {
+    if ($courseid && $courseid != SITEID) {
         require_login($courseid);
     } else if ($CFG->forcelogin) {
         require_login();
@@ -390,7 +390,10 @@ function calendar_show_month_detailed($m, $y, $courses, $groups, $users, $course
         $text.= '</div></form></div>';
     }
 
-    $text .= get_string('detailedmonthview', 'calendar').': '.calendar_course_filter_selector($getvars);
+    $text .= '<label for="cal_course_flt_jump">'.
+               get_string('detailedmonthview', 'calendar').
+             ':</label>'.
+             calendar_course_filter_selector($getvars);
 
     echo '<div class="header">'.$text.'</div>';

But i couldn't find this at git.moodle.org

Also, i have attached a patch (mdl-17510-v2.diff) that adds the labels in the two other functions you saw and also removes some blanks spaces in end of lines and commented code.

Show
Daniel Neis added a comment - Hello, Eloy i think someone else have added the label in another commit (http://cvs.moodle.org/moodle/calendar/view.php?r1=1.95&r2=1.95.2.10) some time ago... I have a clone of git.moodle.org repo, and did a seach "git log -Scal_course_flt_jump calendar/" and have found the commit: 
daniel@judy:~/public_html/moodle$ git show d4d468ad374e344c90eb278092e6e425232b0b66
commit d4d468ad374e344c90eb278092e6e425232b0b66
Author: moodler <moodler>
Date:   Thu Oct 1 07:02:15 2009 +0000

    calendar MDL-19940 Don't require login for site calendar when forcelogin is false

diff --git a/calendar/view.php b/calendar/view.php
index eeedb32..92abf88 100644
--- a/calendar/view.php
+++ b/calendar/view.php
@@ -54,7 +54,7 @@
         redirect($CFG->wwwroot.'/'.$CFG->admin.'/index.php');
     }
 
-    if ($courseid) {
+    if ($courseid && $courseid != SITEID) {
         require_login($courseid);
     } else if ($CFG->forcelogin) {
         require_login();
@@ -390,7 +390,10 @@ function calendar_show_month_detailed($m, $y, $courses, $groups, $users, $course
         $text.= '</div></form></div>';
     }
 
-    $text .= get_string('detailedmonthview', 'calendar').': '.calendar_course_filter_selector($getvars);
+    $text .= '<label for="cal_course_flt_jump">'.
+               get_string('detailedmonthview', 'calendar').
+             ':</label>'.
+             calendar_course_filter_selector($getvars);
 
     echo '<div class="header">'.$text.'</div>';
But i couldn't find this at git.moodle.org Also, i have attached a patch (mdl-17510-v2.diff) that adds the labels in the two other functions you saw and also removes some blanks spaces in end of lines and commented code.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Hi Daniel,

I've aded the two missing labels, both to 19_STABLE and HEAD, will be available in next weekly build.

About the patch, looked perfect but has some problems inserting some tabs, that are "forbidden" in moodle source code. Just to suggest you to change the settings in your IDE/editor to avoid tabs and use 4cc whites instead.

Many thanks! Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi Daniel, I've aded the two missing labels, both to 19_STABLE and HEAD, will be available in next weekly build. About the patch, looked perfect but has some problems inserting some tabs, that are "forbidden" in moodle source code. Just to suggest you to change the settings in your IDE/editor to avoid tabs and use 4cc whites instead. Many thanks! Ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.