|
posting a screenshot with text in english
Hi Daniel,
I've been looking at this and, in the detailed month view I'm getting that HTML within one label, exactly as your patch does: <label for="cal_course_flt_jump">Detailed Month View:</label> Curiously, looking a bit more in calendar/lib.php, I've seen that there are three places where That label should be present:
Ciao Hello, Eloy
i think someone else have added the label in another commit (http://cvs.moodle.org/moodle/calendar/view.php?r1=1.95&r2=1.95.2.10 daniel@judy:~/public_html/moodle$ git show d4d468ad374e344c90eb278092e6e425232b0b66
commit d4d468ad374e344c90eb278092e6e425232b0b66
Author: moodler <moodler>
Date: Thu Oct 1 07:02:15 2009 +0000
calendar MDL-19940 Don't require login for site calendar when forcelogin is false
diff --git a/calendar/view.php b/calendar/view.php
index eeedb32..92abf88 100644
--- a/calendar/view.php
+++ b/calendar/view.php
@@ -54,7 +54,7 @@
redirect($CFG->wwwroot.'/'.$CFG->admin.'/index.php');
}
- if ($courseid) {
+ if ($courseid && $courseid != SITEID) {
require_login($courseid);
} else if ($CFG->forcelogin) {
require_login();
@@ -390,7 +390,10 @@ function calendar_show_month_detailed($m, $y, $courses, $groups, $users, $course
$text.= '</div></form></div>';
}
- $text .= get_string('detailedmonthview', 'calendar').': '.calendar_course_filter_selector($getvars);
+ $text .= '<label for="cal_course_flt_jump">'.
+ get_string('detailedmonthview', 'calendar').
+ ':</label>'.
+ calendar_course_filter_selector($getvars);
echo '<div class="header">'.$text.'</div>';
But i couldn't find this at git.moodle.org Also, i have attached a patch (mdl-17510-v2.diff) that adds the labels in the two other functions you saw and also removes some blanks spaces in end of lines and commented code. Hi Daniel,
I've aded the two missing labels, both to 19_STABLE and HEAD, will be available in next weekly build. About the patch, looked perfect but has some problems inserting some tabs, that are "forbidden" in moodle source code. Just to suggest you to change the settings in your IDE/editor to avoid tabs and use 4cc whites instead. Many thanks! Ciao |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
couldn't find them after submit the issue...