Details
Bug
Closed
Major
Description
the delete function delete all datasetdefiniton used by this question without testing if they are shared by other questions.
if ($datasets = get_records('question_datasets', 'question', $questionid)) {
foreach ($datasets as $dataset) {
delete_records('question_dataset_definitions', 'id', $dataset->datasetdefinition);
delete_records('question_dataset_items', 'definition', $dataset->datasetdefinition);
}
}
changing this in HEAD to
if ($datasets = $DB->get_records('question_datasets', array('question' => $questionid))) {
foreach ($datasets as $dataset) {
if (!$DB->get_records_select( // no other questions sharing this datasetdefinition
'question_datasets',
"question != ?
AND datasetdefinition = ?;", array($questionid, $dataset->datasetdefinition))){
$DB->delete_records('question_dataset_definitions', array('id' => $dataset->datasetdefinition));
$DB->delete_records('question_dataset_items', array('definition' => $dataset->datasetdefinition));
}
}
}
solve the problem.
will merge down to 1.6
We can conclude that either shared datasetdefinition are not so often used or that such calculated questions are too precious to be deleted ...
for 1.9 and older version this becomes
+ if (! get_records_select(
+ 'question_datasets',
+ "question != $questionid
+ AND datasetdefinition = $dataset->datasetdefinition;")){ + delete_records('question_dataset_definitions', 'id', $dataset->datasetdefinition); + delete_records('question_dataset_items', 'definition', $dataset->datasetdefinition); + }