Issue Details (XML | Word | Printable)

Key: MDL-17548
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Martin Dougiamas
Reporter: Jonathan Harker
Votes: 1
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

MNET jump links in forum emails have incorrect path when wwwroot contains a path

Created: 08/Dec/08 08:15 AM   Updated: 25/Mar/09 12:53 AM
Return to search
Component/s: Forum, Messages, Networking
Affects Version/s: 1.9.3, 2.0
Fix Version/s: 1.9.4

File Attachments: 1. Text File MDL-17548.HEAD.patch (1.0 kB)
2. Text File MDL-17548.MOODLE_19_STABLE.patch (1.0 kB)


Participants: Dan Poltawski, Eloy Lafuente (stronk7), Jonathan Harker, Martin Dougiamas and Peter Bulmer
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 23/Mar/09
Affected Branches: MOODLE_19_STABLE, MOODLE_20_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
If $CFG->wwwroot contains a path component (e.g. /moodle in http://contentprovider.com/moodle or similar), then the MNET jump URLs to the forum threads on the CP that get written into forum emails contain a double-up of the path - on the end of hostwwwroot and the beginning of wantsurl. For instance:

http://idprovider.com/mnet/jump.php?hostwwwroot=http://contentprovider.com/moodle&wantsurl=/moodle/mod/forum/discuss.php...

Attached fix.


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Jonathan Harker added a comment - 08/Dec/08 12:51 PM
Patch for head - PHP 5 supports the extra PHP_URL_PATH parameter.

Jonathan Harker added a comment - 08/Dec/08 12:53 PM
Fix for MOODLE_19_STABLE has to support the PHP 4 incantation of parse_url

Dan Poltawski added a comment - 12/Dec/08 08:20 AM
(Not really looked at this - ). But presumably this fixes the wantsurl part?

Peter Bulmer added a comment - 12/Dec/08 08:43 AM
DanP, Yep.

I've looked at it, it's a good patch IMO


Eloy Lafuente (stronk7) added a comment - 12/Dec/08 09:06 AM
+1 yay!

Jonathan Harker added a comment - 15/Dec/08 08:41 AM
Now committed to HEAD and MOODLE_19_STABLE
Cheers again
J

Dan Poltawski added a comment - 23/Mar/09 08:28 AM
Closing as fixed as this has been commited