Moodle

jumpmenu should use CSS instead of align="center"

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4
  • Component/s: General
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

On the course homepage, the following code is used to center the jump menu:

<div align="center" class="jumpmenu">

This is invalid XHTML. To fix, replace the above code with:

<div style="text-align: center;" class="jumpmenu">

Or better yet, remove the align attribute and add the equivalent CSS declaration to the jumpmenu class.

The fix need to be made on line 329 of: /course/format/lams/format.php

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Assignnig to Dongsheng... can you plz review all course format to see how this is being used? And do it in the correct way for formats using the incorrect one?

TIA, ciao

Show
Eloy Lafuente (stronk7) added a comment - Assignnig to Dongsheng... can you plz review all course format to see how this is being used? And do it in the correct way for formats using the incorrect one? TIA, ciao
Hide
Dongsheng Cai added a comment -

Fixed many align properties in div.

Show
Dongsheng Cai added a comment - Fixed many align properties in div.
Hide
Petr Škoda (skodak) added a comment -

reviewed, thanks, closing

Show
Petr Škoda (skodak) added a comment - reviewed, thanks, closing

People

Dates

  • Created:
    Updated:
    Resolved: