[#MDL-17570] jumpmenu should use CSS instead of align="center"

Issue Details (XML | Word | Printable)

Key:	MDL-17570
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Trivial
Assignee:	Dongsheng Cai
Reporter:	Liam Morland
Votes:	0
Watchers:	3

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

jumpmenu should use CSS instead of align="center"

Created: 10/Dec/08 04:11 AM Updated: 31/Dec/08 12:51 AM

Return to search

Component/s:

General

Affects Version/s:

1.9.3

Fix Version/s:

1.9.4

Participants:	Dongsheng Cai, Eloy Lafuente (stronk7), Liam Morland and Petr Skoda
Security Level:	None
QA Assignee:	Petr Skoda
Difficulty:	Easy
Resolved date:	10/Dec/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

On the course homepage, the following code is used to center the jump menu:

<div align="center" class="jumpmenu">

This is invalid XHTML. To fix, replace the above code with:

<div style="text-align: center;" class="jumpmenu">

Or better yet, remove the align attribute and add the equivalent CSS declaration to the jumpmenu class.

The fix need to be made on line 329 of: /course/format/lams/format.php

All

Comments

Change History

Version Control

Sort Order:

Dongsheng Cai committed 20 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Dec/08 03:05 PM

"~~MDL-17570~~, cleanup align property in div"

MODIFY	mod/hotpot/index.php	Rev. 1.26.2.6	(+2 -2 lines)
MODIFY	mod/lesson/highscores.php	Rev. 1.6.4.1	(+5 -5 lines)
MODIFY	admin/replace.php	Rev. 1.8.4.2	(+2 -2 lines)
MODIFY	mod/forum/lib.php	Rev. 1.609.2.73	(+2 -2 lines)
MODIFY	admin/lang.php	Rev. 1.106.2.12	(+2 -2 lines)
MODIFY	theme/standard/styles_layout.css	Rev. 1.516.2.70	(+2 -0 lines)
MODIFY	mod/wiki/ewiki/plugins/moodle/downloads.php	Rev. 1.16.4.1	(+2 -2 lines)
MODIFY	course/format/lams/Attic/format.php	Rev. 1.25.2.2	(+2 -2 lines)
MODIFY	course/format/weekscss/Attic/format.php	Rev. 1.24.2.5	(+2 -2 lines)
MODIFY	course/format/weeks/format.php	Rev. 1.74.2.6	(+2 -2 lines)
MODIFY	mod/scorm/report.php	Rev. 1.46.2.7	(+3 -3 lines)
MODIFY	mod/resource/type/file/Attic/localfile.php	Rev. 1.6.4.2	(+3 -3 lines)
MODIFY	mod/resource/type/file/Attic/localpath.php	Rev. 1.5.4.3	(+3 -3 lines)
MODIFY	course/format/topics/format.php	Rev. 1.83.2.3	(+2 -2 lines)
MODIFY	mod/data/lib.php	Rev. 1.137.2.42	(+2 -2 lines)
MODIFY	mod/hotpot/view.php	Rev. 1.38.2.6	(+3 -3 lines)
MODIFY	search/query.php	Rev. 1.16.2.6	(+3 -3 lines)
MODIFY	enrol/paypal/enrol.php	Rev. 1.28.2.4	(+2 -2 lines)
MODIFY	message/lib.php	Rev. 1.61.2.13	(+1 -1 lines)
MODIFY	admin/Attic/langdoc.php	Rev. 1.20.4.3	(+3 -3 lines)

Dongsheng Cai committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Dec/08 03:07 PM

"~~MDL-17570~~, clean up align property in div"

MODIFY

search/querylib.php

Rev. 1.7.2.4

(+2 -2 lines)

Dongsheng Cai committed 17 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Dec/08 03:30 PM

"~~MDL-17570~~, cleanup inline css settings"

MODIFY	search/query.php	Rev. 1.16.2.7	(+1 -1 lines)
MODIFY	mod/hotpot/index.php	Rev. 1.26.2.7	(+2 -2 lines)
MODIFY	search/querylib.php	Rev. 1.7.2.5	(+1 -1 lines)
MODIFY	mod/forum/lib.php	Rev. 1.609.2.74	(+2 -2 lines)
MODIFY	admin/Attic/langdoc.php	Rev. 1.20.4.4	(+3 -3 lines)
MODIFY	enrol/authorize/enrol.php	Rev. 1.135.2.7	(+2 -2 lines)
MODIFY	enrol/paypal/enrol.php	Rev. 1.28.2.5	(+2 -2 lines)
MODIFY	mod/data/lib.php	Rev. 1.137.2.43	(+2 -2 lines)
MODIFY	admin/lang.php	Rev. 1.106.2.13	(+2 -2 lines)
MODIFY	admin/replace.php	Rev. 1.8.4.3	(+2 -2 lines)
MODIFY	mod/resource/type/file/Attic/localpath.php	Rev. 1.5.4.4	(+2 -2 lines)
MODIFY	mod/hotpot/view.php	Rev. 1.38.2.7	(+3 -3 lines)
MODIFY	mod/scorm/report.php	Rev. 1.46.2.8	(+3 -3 lines)
MODIFY	mod/lesson/highscores.php	Rev. 1.6.4.2	(+3 -3 lines)
MODIFY	mod/resource/type/file/Attic/localfile.php	Rev. 1.6.4.3	(+2 -2 lines)
MODIFY	mod/wiki/ewiki/plugins/moodle/downloads.php	Rev. 1.16.4.2	(+2 -2 lines)
MODIFY	message/lib.php	Rev. 1.61.2.14	(+1 -1 lines)

Dongsheng Cai committed 18 files to 'Moodle CVS' - 10/Dec/08 03:48 PM

"~~MDL-17570~~, cleanup align property in div, merged from 1.9"

MODIFY	mod/scorm/report.php	Rev. 1.56	(+3 -3 lines)
MODIFY	mod/forum/lib.php	Rev. 1.755	(+2 -2 lines)
MODIFY	search/query.php	Rev. 1.31	(+3 -4 lines)
MODIFY	message/lib.php	Rev. 1.81	(+1 -1 lines)
MODIFY	mod/resource/type/file/Attic/localfile.php	Rev. 1.10	(+2 -2 lines)
MODIFY	mod/data/lib.php	Rev. 1.212	(+2 -2 lines)
MODIFY	course/format/topics/format.php	Rev. 1.93	(+2 -2 lines)
MODIFY	search/querylib.php	Rev. 1.14	(+2 -2 lines)
MODIFY	mod/wiki/ewiki/plugins/moodle/downloads.php	Rev. 1.19	(+2 -2 lines)
MODIFY	mod/lesson/highscores.php	Rev. 1.13	(+4 -4 lines)
MODIFY	mod/hotpot/index.php	Rev. 1.37	(+2 -2 lines)
MODIFY	course/format/weeks/format.php	Rev. 1.86	(+2 -2 lines)
MODIFY	mod/hotpot/view.php	Rev. 1.46	(+3 -3 lines)
MODIFY	theme/standard/styles_layout.css	Rev. 1.653	(+2 -0 lines)
MODIFY	mod/resource/type/file/Attic/localpath.php	Rev. 1.8	(+3 -3 lines)
MODIFY	enrol/paypal/enrol.php	Rev. 1.32	(+1 -1 lines)
MODIFY	admin/lang.php	Rev. 1.123	(+2 -2 lines)
MODIFY	admin/replace.php	Rev. 1.15	(+2 -2 lines)

Dongsheng Cai committed 11 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Dec/08 04:09 PM

"~~MDL-17570~~, cleanup inline css"

MODIFY	blog/rsslib.php	Rev. 1.12.2.2	(+1 -1 lines)
MODIFY	mod/forum/lib.php	Rev. 1.609.2.75	(+3 -3 lines)
MODIFY	mod/exercise/Attic/locallib.php	Rev. 1.28.2.4	(+2 -2 lines)
MODIFY	enrol/authorize/enrol_form.php	Rev. 1.16.2.4	(+2 -2 lines)
MODIFY	mod/resource/type/repository/Attic/resource.class.php	Rev. 1.21.2.3	(+3 -3 lines)
MODIFY	lib/adodb/adodb-perf.inc.php	Rev. 1.15.6.3	(+2 -2 lines)
MODIFY	mod/resource/type/file/Attic/resource.class.php	Rev. 1.71.2.20	(+4 -4 lines)
MODIFY	theme/standard/styles_layout.css	Rev. 1.516.2.71	(+6 -0 lines)
MODIFY	question/type/datasetdependent/Attic/datasetdefinitions_form.php	Rev. 1.7.2.2	(+2 -2 lines)
MODIFY	admin/lang.php	Rev. 1.106.2.14	(+4 -4 lines)
MODIFY	mod/wiki/ewiki/ewiki.php	Rev. 1.36.2.6	(+3 -3 lines)

Dongsheng Cai committed 22 files to 'Moodle CVS' - 10/Dec/08 04:24 PM

"~~MDL-17570~~,clean align property, merged from 1.9"

MODIFY	lib/adodb/adodb-perf.inc.php	Rev. 1.19	(+2 -2 lines)
MODIFY	mod/forum/lib.php	Rev. 1.756	(+3 -3 lines)
MODIFY	mod/feedback/use_templ.php	Rev. 1.6	(+3 -3 lines)
MODIFY	theme/standard/styles_layout.css	Rev. 1.654	(+6 -0 lines)
MODIFY	mod/feedback/analysis_course.php	Rev. 1.8	(+4 -4 lines)
MODIFY	question/type/calculated/datasetdefinitions_form.php	Rev. 1.2	(+2 -2 lines)
MODIFY	mod/feedback/view.php	Rev. 1.10	(+4 -4 lines)
MODIFY	mod/feedback/complete.php	Rev. 1.14	(+4 -4 lines)
MODIFY	mod/feedback/import.php	Rev. 1.7	(+3 -3 lines)
MODIFY	mod/feedback/show_entries.php	Rev. 1.9	(+5 -5 lines)
MODIFY	mod/resource/type/repository/Attic/resource.class.php	Rev. 1.26	(+3 -3 lines)
MODIFY	admin/lang.php	Rev. 1.124	(+4 -4 lines)
MODIFY	mod/feedback/delete_template.php	Rev. 1.7	(+3 -3 lines)
MODIFY	mod/feedback/print.php	Rev. 1.7	(+3 -3 lines)
MODIFY	enrol/authorize/enrol_form.php	Rev. 2.8	(+2 -2 lines)
MODIFY	blog/rsslib.php	Rev. 1.16	(+1 -1 lines)
MODIFY	mod/wiki/ewiki/ewiki.php	Rev. 1.47	(+2 -2 lines)
MODIFY	mod/feedback/show_entries_anonym.php	Rev. 1.6	(+3 -3 lines)
MODIFY	mod/feedback/analysis.php	Rev. 1.10	(+4 -4 lines)
MODIFY	mod/feedback/complete_guest.php	Rev. 1.10	(+4 -4 lines)
MODIFY	enrol/authorize/enrol.php	Rev. 2.28	(+2 -2 lines)
MODIFY	mod/resource/type/file/Attic/resource.class.php	Rev. 1.91	(+4 -4 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.