Issue Details (XML | Word | Printable)

Key: MDL-17575
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: Petr Skoda
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

yet more course request improvements

Created: 10/Dec/08 06:58 AM   Updated: 17/Dec/08 11:36 PM
Return to search
Component/s: Course
Affects Version/s: 1.9.3
Fix Version/s: 1.9.4

File Attachments: 1. Text File request_improvements2.patch (9 kB)

Participants: Helen Foster, Petr Skoda and Tim Hunt
Security Level: None
Resolved date: 10/Dec/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
while testing the changes in course request I realised I still miss some features:
1/ email notification when course requested
2/ course request capability so that we can limit who can request new course
3/ list of my pending course requests

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Petr Skoda added a comment - 10/Dec/08 07:00 AM - edited
I could not resist and created a patch

Petr Skoda made changes - 10/Dec/08 07:00 AM
Field Original Value New Value
Attachment request_improvements2.patch [ 15845 ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 10/Dec/08 07:55 AM
Don't you know you are supposed to search for existing issues before you file a new one? What sort of ignorant end-user are you MDL-6160

I'll review this patch later today. Thanks.


Tim Hunt made changes - 10/Dec/08 07:55 AM
Fix Version/s 1.9.4 [ 10300 ]
tjhunt committed 8 files to 'Moodle CVS' - 10/Dec/08 11:57 AM
course request: MDL-17575 and MDL-6160 further improvements:

1/ email notification when course requested
2/ course request capability so that we can limit who can request new course
3/ list of my pending course requests on the request form

Implemented in 1.9 by Petr Skoda, and reviewed and merged to HEAD by me.
MODIFY lib/db/access.php   Rev. 1.98    (+9 -1 lines)
MODIFY version.php   Rev. 1.915    (+1 -1 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.245    (+4 -0 lines)
MODIFY course/request_form.php   Rev. 1.17    (+13 -1 lines)
MODIFY course/request.php   Rev. 1.20    (+30 -2 lines)
MODIFY admin/settings/courses.php   Rev. 1.29    (+2 -1 lines)
MODIFY course/lib.php   Rev. 1.629    (+2 -2 lines)
MODIFY lang/en_utf8/role.php   Rev. 1.85    (+2 -1 lines)
tjhunt committed 8 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Dec/08 11:57 AM
course request: MDL-17575 and MDL-6160 further improvements:

1/ email notification when course requested
2/ course request capability so that we can limit who can request new course
3/ list of my pending course requests on the request form

Implemented in 1.9 by Petr Skoda, and reviewed and merged to HEAD by me.
MODIFY admin/settings/courses.php   Rev. 1.14.2.7    (+2 -1 lines)
MODIFY version.php   Rev. 1.563.2.340    (+1 -1 lines)
MODIFY course/lib.php   Rev. 1.538.2.64    (+2 -2 lines)
MODIFY course/request.php   Rev. 1.14.2.2    (+20 -2 lines)
MODIFY lib/db/access.php   Rev. 1.75.2.17    (+9 -1 lines)
MODIFY lang/en_utf8/role.php   Rev. 1.47.2.18    (+2 -1 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.154.2.68    (+4 -0 lines)
MODIFY course/request_form.php   Rev. 1.11.2.4    (+13 -1 lines)
[ Permalink | « Hide ]
Tim Hunt added a comment - 10/Dec/08 11:58 AM
Thanks Petr. I merged it to HEAD, and I think this time I managed to convert all the database calls properly

Tim Hunt made changes - 10/Dec/08 11:58 AM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
martignoni committed 2 files to 'Lang CVS' - 10/Dec/08 06:27 PM
New strings translated for MDL-17575 and MDL-6160
MODIFY fr_utf8/admin.php   Rev. 1.322    (+4 -1 lines)
MODIFY fr_utf8/role.php   Rev. 1.106    (+2 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 10/Dec/08 09:50 PM
MDL-17575, forgotten string
MODIFY fr_utf8/admin.php   Rev. 1.325    (+4 -3 lines)
Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 11/Dec/08 01:36 PM
MDL-17429 MDL-16867 Translated new strings fro admin.
MDL-16583 Translated a new string for the close_window function.
MDL-17575 Translated a new string for role.
MODIFY ja_utf8/role.php   Rev. 1.85    (+2 -1 lines)
MODIFY ja_utf8/README   Rev. 1.889    (+1 -1 lines)
MODIFY ja_utf8/admin.php   Rev. 1.323    (+8 -2 lines)
MODIFY ja_utf8/moodle.php   Rev. 1.338    (+3 -2 lines)
[ Permalink | « Hide ]
Helen Foster added a comment - 17/Dec/08 11:36 PM
Thanks Petr and Tim

Course request capability documentation added:

http://docs.moodle.org/en/Capabilities/moodle/course:request
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators