Issue Details (XML | Word | Printable)

Key: MDL-17697
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Dongsheng Cai
Reporter: David Horat
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Extra </div> in a popup in the module resource -> file

Created: 19/Dec/08 10:39 PM   Updated: 03/Mar/09 05:46 PM
Return to search
Component/s: Accessibility
Affects Version/s: 1.9.3
Fix Version/s: 1.9.5

Issue Links:
Duplicate
 

Participants: David Horat, Dongsheng Cai, Eloy Lafuente (stronk7) and Tim Hunt
Security Level: None
QA Assignee: Tim Hunt
Resolved date: 18/Feb/09
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Steps to reproduce
===============
1. Add a resource -> link to a file or website

2. Insert whichever file you want
2.1 File link examples used (Doesn´t matter if they don´t existe):
        http://www.google.com/index.swf
        http://www.google.com/index.avi
        http://www.google.com/index.mp3
2.2 This doesn´t happen if you link to another HTML file.

3. Set the option Window: New Window

4. Save and return to course

5. Click on the newly created resource

6. Click on the popup link (the error is in the popup window)


Current output (with the extra </div>)
===============
<div id="page">
    <!-- END OF HEADER -->
    <div id="content" class=" clearfix"><div class="resourcecontent resourceswf"><object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000"><param name="movie" value="http://127.0.0.1/moodle/file.php/3/Media_examples/muffins_from_space.swf" /><param name="autoplay" value="true" /><param name="loop" value="true" /><param name="controller" value="true" /><param name="scale" value="aspect" /><param name="base" value="." /><!--[if !IE]>--><object type="application/x-shockwave-flash" data="http://127.0.0.1/moodle/file.php/3/Media_examples/muffins_from_space.swf"><param name="controller" value="true" /><param name="autoplay" value="true" /><param name="loop" value="true" /><param name="scale" value="aspect" /><param name="base" value="." /><!--<![endif]--><a href="http://127.0.0.1/moodle/file.php/3/Media_examples/muffins_from_space.swf">http://127.0.0.1/moodle/file.php/3/Media_examples/muffins_from_space.swf&lt;/a&gt;&lt;!--[if !IE]>--></object><!--<![endif]--></object></div><div class="box generalbox generalboxcontent boxaligncenter"><p>Linking to a Flash file will see it displayed like this.</p></div><div class="popupnotice">(<a href="http://127.0.0.1/moodle/file.php/3/Media_examples/muffins_from_space.swf">Direct link to this file</a>)</div></div></div><div id="footer"><hr /><p class="helplink"><a href="http://docs.moodle.org/en/mod/resource/view"><img class="iconhelp" src="http://127.0.0.1/moodle/pix/docs.gif" alt="" />Moodle Docs for this page</a></p><div class="logininfo">You are logged in as <a href="http://127.0.0.1/moodle/user/view.php?id=2&amp;course=3">David Horat</a> (<a href="http://127.0.0.1/moodle/login/logout.php?sesskey=TYhwBRrrKK">Logout</a>)</div><div class="homelink"><a href="http://127.0.0.1/moodle/course/view.php?id=3">Features</a></div></div>
</div>

Other testing
===============
I have also tested this issue in http://demo.moodle.org/ and it happens there too.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 20/Dec/08 04:33 AM
Hi David,

are you sure that happens when linking to a existing page? I've tried creating one "link to a file or website" resource, pointing to http://dialnet.unirioja.es (that is proper XHTML) and the resource showed into Moodle is also XHTML.

Viewing your pasted code above... it seems that you linked to something having a flash or so? More yet, the "link to a file or website" resource shouldn't add Moodle's header and footer at all. Uhm... can you give some more details about WHAT has been linked in your resource?

Ciao


David Horat added a comment - 20/Dec/08 05:54 AM
Updated the "Steps to reproduce" instructions.

Eloy Lafuente (stronk7) added a comment - 18/Jan/09 06:24 AM
Assigning to Dongsheng as he is used with this sort of things TIA!

Dongsheng Cai added a comment - 18/Feb/09 05:11 PM
Fixed

Tim Hunt added a comment - 03/Mar/09 05:21 PM
The commit for this bug got linked to MDL-17696 by mistake.

Tim Hunt added a comment - 03/Mar/09 05:46 PM
Dongshen, pop-up windows, we normally do print_footer('empty'); I think that would be more appropriate here too.