|
[
Permalink
| « Hide
]
Eloy Lafuente (stronk7) added a comment - 20/Dec/08 01:06 AM
Assigning to Helen... could you, plz, take a look to all those help files and make them to validate properly? TIA!
Helen and David
I tried to correct the help files in italian but I noticed that only by changing '<P ' to '<p ' '</P>' to '</p>' 'align=center' to 'align="center"' 'ALIGN=CENTER' to 'align="center"' '<FONT' to '<font '</FONT>' to '</font> '<B>' to '<b>' or, better, '<strong>' '</B>' to '</b>' or, better, '</strong>', most of the problems left. Maybe it can be of help a bulk substitution in all moodledata/lang. Hoping this may be of help for Moodle. Merry Xmas. Hello Daniele,
Thank you very much for your effort. I think that this issue should be check manually for all help files in all languages. The current problem is that we can not automate the process of correcting the file because of several reasons:
The most common mistakes I have found in help files are:
But probably there are some more out there ... To make your work easier you can use the W3C Validator: Be sure to specify the option "Validate HTML Fragment" to XHTML 1.0 David, thanks for reporting this issue, and Daniele, thanks for your comments
Adding Koen as a watcher for advice on how best to ensure help files in all languages validate. I'm afraid it should be done manually. It's a little bit sad this problem crops up again - I went through the all the language packs somewhere around 1.5 or 1.6 I think. Very time consuming.
Initial report with all the language help files that do not comply with XHTML 1.0 Strict. It seems that the problem is all around.
hm, 7000 problematic files. That's a lot.
Can I ask you how you created the list? Yes. I created a bash script that checkouts out all CVS language files from es.cvs.moodle.org/cvsroot/moodle/lang/, for each individual file I reconstruct it as a whole valid XHTML file, adding header(DOCTYPE, html, header, body) and footer(body, html), I parse them with OpenSP (http://openjade.sourceforge.net/
 ) which is the engine behind the W3C Validator (http://validator.w3.org/) and at the end I use sed to make up the final report with all the pages that are not valid.
If you want I could work on it a bit more, wrap all needed things up and upload them here. Report with one non-valid help file per line. No extra numbers at the end.
Hi Koen and all,
Here is the script I did. Give it a try if you want. Regards, Ciao David and thanks for your script.
I tried to use it but I fall into: quit 2 'onsgmls file not found. Please install it from your repository.' I added: and I changed Whay your script is working to your computer and not to mine? My ubuntu results with about 15000 times "onsgmls: error while loading shared libraries: libosp.so.5: cannot open shared object file: No such file or directory " in the log-file.
Running "sudo apt-get install libosp5" didn't solve it.. I had a look at the results of the script, looked in the nl_utf8 langpack since I maintain that and found that it will be very hard to fix everything manually. The first file I looked at (survey.html) I don't see anything wrong, the second one, context.html had one </p> to many and missed one </li>... I think going through all the language files (manually) to fix them, is a useless job unless we find some way to keep them clean afterwards. Some script that validates on saving with the language pack editor may be? There are not that many different tags used in the help files. running apt-get install w3c-dtd-xhtml got me a little bit further. I get now
onsgmls:lang/af_utf8/help/courseformats.html:5:28:E: end tag for element "b" which is not open |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Open
Minor
Help files (en_utf8) do not comply with XHTML 1.0 Strict
 |
|
