Moodle

Addressing for 1.9.4 and assigning to Dongsheg too (it's the multimedia filter if I'm not wrong, Dong). Not sure.

Fixed, please review, thanks

It would be better not to use inline styles, but rather a CSS selector instead of
<div id="'.$div_id.'" style="display:inline"></div>

If there is none that you could reuse in the default CSS theme, you could add a new one for objects.

Fixed again, thanks david.

Your welcome.

Due to the changes made by patches 1.38.2.7 and 1.38.2.8 the text about flash player not installed on client's computer inside <span> is always displayed (the span has other id, so the text is not replaced by javascript). This caused regression to all pages, where swf, mp3 or flv files are inserted via media_plugin filter, not via resource. As I understand, when swf or mp3 resources are inserted into course, the media_plugin filter is not used. When the object is inserted via media_plugin, it is always inside <span>, is it allowed by XHTML strict? If it is, another <div> is not necessary.
I propose to revert these patches and revise the problem of XHTML strict code in media objects.

The recent changes in the display of an embedded MP3 player ruin my Moodle course displays!

I need to embed MP3 players within paragraphs. But because of the extra <div> tag which has been added (further to David's suggestion), it is now impossible for me to do so. On top of it I get a validtion error because of course <div> tags are not allowed inside <p></p> paragraphs.

I suggest replacing that <div> tag with a <span> tag. I have tried it and it works and there is no validation problem.

Attached screenshots_JR show what is displayed with current <div> MP3 div tag (#1) vs the display using my suggested replacement with a <span> tag (#2). Unless there are adverse effects I strongly insist that my suggestion be applied as soon as possible, to restore my current moodle course functionality.

Thanks,
Joseph

This needs to be re-opened, see my previous comment and screenshots.
Joseph

Unfortunately the <span> tag instead of the <div> doesn´t work when the MP3 is included as a resource because the <object> tag must be included into a block tag (div, p, etc.).

In your case it worked because when you embed it in the middle of a text, there is no <noscript> tag around the object and the text is usually surrounded by either <p> or <div>.

Thus, we have a problem here.

One possible solution is to use the <span> tag for the filter and when using it as a resource add a <div> tag. We can also make all resources be around a <div> tag. Maybe someone else knows which is the best solution or if there is a better one.

Regards,
David

David, what exactly do you mean by "when the MP3 is included as a resource" ?
Do you mean: Add a resource / Link to a file or website / Choose or upload a file / Select an MP3 file from the course Files ?
This results in the "huge" mp3 player to be displayed all alone on one page (which does not validate, by the way).
I don't think many people use that way of displaying MP3 files.
Or what else do you mean?
Joseph

Yes, I meant exactly that.

The "huge player" depends on what you use to render audio/mpeg mime type in your browser. But it is usually that way.

Version 1.9.3 + the div tag validated. I haven´t tested 1.9.4.

Anyway, I agree with you that the current fix can break some exercises as yours, so some of the solutions I proposed or others should be done.

I have to revert this patch to make filter working with in p tag, it is impossible to use p or div tags within p, so we cannot use div here, any good suggestion is welcomed.

TIA.

I don't understand why filter/mediaplugin/filter.php has been modified? Problem occurs with RESOURCE "mp3-file"? AFAIK resources have own implemetation of inserting media-objects. See mod/resource/type/file/resource.class.php:~520

Shouldn't use div tag inside p tag

Uhm... reviewing this... which is current status? It seems that the original bug talks about resources adding mp3, and not about contents handled by multimedia filter (my fault, because I did that assumption in my first reply here).

So... David, Dongsheng... is it ok to have this resolved or do we need to modify anything in resource code? Also, the multimedia filter has been reverted to original status, correct?

Reopening until reply arrives... ciao

Well, it seems that the problems is still there so it still needs to be fixed. I haven´t tested it in 1.9.4 since I am currently not developing in Moodle.

Hi, David, seems we cannot use div inside p tags, so we shouldn't use div here.

David, I have reverted the old version since we should NOT use div inside p tags, do you agree, if so this bug will be resolved as "won't fix"

Dongsheng Cai " have reverted the old version since we should use div inside p tags..."

Dongsheng, I suppose you mean "since we should NOT use div inside p tags" ?
Joseph

Yes, sorry for typo

Right now I don't have time to fix it since I just changed job and residence. Anyway, it should be fixed in the future because Accesibility Laws in both US and EU are very clear in these kind of things.

close it, waiting for a better solution, feel free to reopen it if you have better idea