Moodle

The Glossary summary is wrapped by a <p> tag when viewing it but it should be wrapped by a <div> tag

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4, 2.0
  • Component/s: Accessibility, Glossary
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

When creating a glossary, in its summary, people tend to use tags such as <p>, <ul>, <ol> or even <div> because they want to create paragraphs. The problem is that when someone watches a glossary, its summary is wrapped with the <p> tag, which doesnt allow does tags inside. Example of a normal generated summary:
<div id="intro" class="generalbox box">
<p>
This is a glossary test
</p>
</div>

Note that "This glossary test" was written without the <p> tag in the summary editor, but if we want to create two paragrapas in the summary, such as:
<p>This is glossary test</p>
<p>This are its specifications</p>

This will be translated to:
<div id="intro" class="generalbox box"><p>
<p>This is glossary test</p>
<p>This are its specifications</p>
</p</div>

Which is, indeed, wrong.

The easiest solution is to change the outer <p> for a <div> tag in the code.

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Assigning to Dongsheng and addressing to 1.9.4 too. Re-thanks David!

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Dongsheng and addressing to 1.9.4 too. Re-thanks David!
Hide
Dongsheng Cai added a comment -

Fixed in 1.9 and HEAD, please review

Show
Dongsheng Cai added a comment - Fixed in 1.9 and HEAD, please review
Hide
David Horat added a comment -

Ok.

Show
David Horat added a comment - Ok.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: