Moodle

The Glossary entry print view uses the tag <p align="center"> and the align attribute is not valid in XHTML 1.0 Strict

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4
  • Component/s: Accessibility, Glossary
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Instead of
<p align="center">
we should use
<p style="text-align: center">

This is done by modify the file: /moodle/mod/glossary/print.php
We should change the line:
echo "<p align=\"center\"><strong>".clean_text($pivottoshow)."</strong></p>" ;
for
echo "<p style=\"text-align: center\"><strong>".clean_text($pivottoshow)."</strong></p>" ;

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Assigning to Dongsheng and addressing to 1.9.4. Thanks David!

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Dongsheng and addressing to 1.9.4. Thanks David!
Hide
Eloy Lafuente (stronk7) added a comment -

As commented in MDL-17709, perhaps it's better to use proper CSS selectors instead of inline styles. Ciao

Show
Eloy Lafuente (stronk7) added a comment - As commented in MDL-17709, perhaps it's better to use proper CSS selectors instead of inline styles. Ciao
Hide
David Horat added a comment -

Your welcome.
I agree Eloy. I would add it in the default theme.

Show
David Horat added a comment - Your welcome. I agree Eloy. I would add it in the default theme.
Hide
Dongsheng Cai added a comment -

Fixed, please review, Thanks

Show
Dongsheng Cai added a comment - Fixed, please review, Thanks
Hide
David Horat added a comment -

Ok.

Show
David Horat added a comment - Ok.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: