Moodle

Forum view does not comply with XHTML 1.0 Strict

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4
  • Component/s: Accessibility, Forum
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

There are several problems here:
1) The same problem as in MDL-17707 but for the forum summary
2) The same problem as in MDL-17708 but for the file /moodle/mod/forum/view.php. So the line
echo '<p align="center">';
should be changed by the line
echo "<p style=\"text-align: center\">";

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Assigning to Dongsheng and addressing to 1.9.4. Re-re-thanks David!

Dongsheng... perhaps instead of using inline styles... we should use proper CSS selector for that. Boith here and in MDL-17708

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Dongsheng and addressing to 1.9.4. Re-re-thanks David! Dongsheng... perhaps instead of using inline styles... we should use proper CSS selector for that. Boith here and in MDL-17708
Hide
Permalink
David Horat added a comment -

Your welcome.
I agree Eloy. I would add it in the default theme.

Show
David Horat added a comment - Your welcome. I agree Eloy. I would add it in the default theme.
Hide
Permalink
Dongsheng Cai added a comment -

Use mdl-align class to center div.
Thanks for reporting.

Show
Dongsheng Cai added a comment - Use mdl-align class to center div. Thanks for reporting.
Hide
Permalink
David Horat added a comment - - edited

The first problem stated is not fixed just with the changes made:
1) The same problem as in MDL-17707 but for the forum summary

Show
David Horat added a comment - - edited The first problem stated is not fixed just with the changes made: 1) The same problem as in MDL-17707 but for the forum summary
Hide
Permalink
Dongsheng Cai added a comment -

Fixed, thanks for testing

Show
Dongsheng Cai added a comment - Fixed, thanks for testing
Hide
Permalink
David Horat added a comment -

Your welcome.

Show
David Horat added a comment - Your welcome.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.