Issue Details (XML | Word | Printable)

Key: MDL-17724
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Steve Bond
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Cannot change case of group (or grouping) name

Created: 23/Dec/08 12:19 AM   Updated: 31/Dec/08 10:14 AM
Component/s: Groups
Affects Version/s: 1.9.2
Fix Version/s: 1.9.4

File Attachments: 1. Text File group.patch (1 kB)


Participants: Eloy Lafuente (stronk7), Petr Skoda and Steve Bond
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Difficulty: Easy
Resolved date: 30/Dec/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
If you try to update the case of a group name (e.g. change "MY GROUP" to "My Group"), you get this error:

The group name 'My Group' already exists in this course, please choose another one.

Same goes for Groupings.

Easy enough to fix this, see attached patch. The scripts concerned already check to see whether the name is unchanged, I just changed that condition so that it does a case-insensitive comparison. As far as I can tell this doesn't cause any other problems.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda added a comment - 30/Dec/08 06:33 AM
I have fixed both groups and groupings using unicode compatible case insensitive comparison, thanks for the report and patch!

Petr


Eloy Lafuente (stronk7) added a comment - 31/Dec/08 10:14 AM
Working ok here. Closing. Thanks!