[#MDL-17754] Session improvements and related rewrites

Issue Details (XML | Word | Printable)

Key:	MDL-17754
Type:	Task
Status:	Open
Priority:	Major
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	1
Watchers:	3

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Session improvements and related rewrites

Created: 31/Dec/08 09:34 PM Updated: 07/Feb/09 07:57 PM

Return to search

Component/s:

General

Affects Version/s:

2.0

Fix Version/s:

2.0

Issue Links:

Relates

This issue has a non-specific relationship to:

~~MDL-14992~~ M2: adodb sessions switched to moodle sessions

~~MDL-7026~~ add new session diagnostics code - both before install and after

~~MDL-17596~~ Install should warn that cookies are needed

~~MDL-3733~~ Session handling in install script

MDL-16640 Bogus sesskey change for existing session results in lost forum posts

MDL-10137 Login problems in IE7 when persistent cookies are not allowed

MDL-14586 Cookies- The log in page teles me I have not enabled cookies. This is not true.

MDL-5374 poor https check

~~MDL-17176~~ sessiontimeout configuration seems to be ignored

~~MDL-9276~~ Errors with Moodle behind a reverse proxy

~~MDL-16613~~ review and fix USER->sesskey and USER->sessionIP handling

~~MDL-14123~~ Full IPv6 support

~~MDL-8925~~ Sessions2 error on upgrade to 1.8

~~MDL-11061~~ SSL Publishing a Moodle site with ISA Server and no SSL Bridging (Browser--ssl--> ISA Server --nonssl --> Moodle) breaks Quiz View

~~MDL-8732~~ Session: connection failed

~~MDL-17776~~ Dehackify handling of CLI scripts

~~MDL-17773~~ refactor creation of links to login page

~~MDL-17777~~ Improve $FULLME, $ME and add $SCRIPT and $FULLSCRIPT

~~MDL-17774~~ Refactor cron USER switching

~~MDL-17788~~ rename pixgroup.php to grouppix.php for better consistency

~~MDL-17767~~ loginas - cleanup and refactoring

~~MDL-17898~~ do not store real object instances into sessions in XMLDB editor

MDL-13064 Add "Log off immediately" to bulk user actions

MDL-16641 Remove all attempts to cast sesskey to BINARY as it was causing MySQL to ignore the preferred index, resulting in slow response time

~~MDL-6843~~ moodle has some problem working with reverse proxy (squid)

~~MDL-17787~~ Replace moodletest cookies with $CFG->wwwroot x $_SERVER comparison

~~MDL-14213~~ CLONE -IP address change error message should contain login link

This issue has been marked as being related by:

~~MDL-17458~~ Install & upgrade 2.0 cleanup META

Participants:	Petr Skoda
Security Level:	None
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Sub-Tasks:

All

Open

Sub-Task Progress:

Unfortunately cookies are currently not enabled in your browser

Open

Petr Skoda

Description

« Hide

List of issues related to sessions

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda made changes - 31/Dec/08 09:34 PM

Field	Original Value	New Value
Link		This issue has a non-specific relationship to ~~MDL-14992~~ [ ~~MDL-14992~~ ]

Petr Skoda made changes - 31/Dec/08 09:34 PM

Link

This issue has a non-specific relationship to MDL-16640 [ MDL-16640 ]

Petr Skoda made changes - 31/Dec/08 09:35 PM

Link

This issue has a non-specific relationship to ~~MDL-3733~~ [ ~~MDL-3733~~ ]

Petr Skoda made changes - 31/Dec/08 09:35 PM

Link

This issue has a non-specific relationship to ~~MDL-7026~~ [ ~~MDL-7026~~ ]

Petr Skoda made changes - 31/Dec/08 09:36 PM

Link

This issue has a non-specific relationship to ~~MDL-17176~~ [ ~~MDL-17176~~ ]

Petr Skoda made changes - 31/Dec/08 09:37 PM

Link

This issue has a non-specific relationship to ~~MDL-8925~~ [ ~~MDL-8925~~ ]

Petr Skoda made changes - 31/Dec/08 09:38 PM

Link

This issue has a non-specific relationship to MDL-16641 [ MDL-16641 ]

Petr Skoda made changes - 31/Dec/08 09:38 PM

Link

This issue has a non-specific relationship to MDL-13064 [ MDL-13064 ]

Petr Skoda made changes - 31/Dec/08 09:40 PM

Link

This issue has a non-specific relationship to ~~MDL-14213~~ [ ~~MDL-14213~~ ]

Petr Skoda made changes - 31/Dec/08 09:41 PM

Link

This issue has a non-specific relationship to MDL-10137 [ MDL-10137 ]

Petr Skoda made changes - 31/Dec/08 09:45 PM

Link

This issue has a non-specific relationship to MDL-14586 [ MDL-14586 ]

Petr Skoda made changes - 31/Dec/08 09:45 PM

Link

This issue has a non-specific relationship to ~~MDL-17596~~ [ ~~MDL-17596~~ ]

Petr Skoda made changes - 31/Dec/08 09:46 PM

Link

This issue has a non-specific relationship to MDL-16723 [ MDL-16723 ]

Petr Skoda made changes - 31/Dec/08 09:47 PM

Link

This issue has a non-specific relationship to ~~MDL-9276~~ [ ~~MDL-9276~~ ]

Petr Skoda made changes - 31/Dec/08 09:47 PM

Link

This issue has a non-specific relationship to ~~MDL-6843~~ [ ~~MDL-6843~~ ]

Petr Skoda made changes - 31/Dec/08 09:48 PM

Link

This issue has a non-specific relationship to MDL-5374 [ MDL-5374 ]

Petr Skoda made changes - 02/Jan/09 07:35 PM

Link

This issue has a non-specific relationship to ~~MDL-16613~~ [ ~~MDL-16613~~ ]

Petr Skoda committed 9 files to 'Moodle CVS' - 02/Jan/09 10:42 PM

MDL-17754 session code refactoring; removing test cookie which will be replaced by wwwroot checks

MODIFY	login/index.php	Rev. 1.139	(+5 -5 lines)
MODIFY	lib/filelib.php	Rev. 1.117	(+7 -7 lines)
MODIFY	index.php	Rev. 1.217	(+3 -3 lines)
MODIFY	lib/setup.php	Rev. 1.252	(+5 -17 lines)
MODIFY	blocks/login/block_login.php	Rev. 1.29	(+2 -2 lines)
MODIFY	lib/sessionlib.php	Rev. 1.4	(+236 -266 lines)
MODIFY	lib/moodlelib.php	Rev. 1.1135	(+4 -53 lines)
MODIFY	auth/shibboleth/login.php	Rev. 1.7	(+2 -2 lines)
MODIFY	login/confirm.php	Rev. 1.34	(+2 -2 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 02/Jan/09 10:58 PM

MDL-17754 loginas internals refactoring - code moved to sessionlib.php

MODIFY	course/loginas.php		Rev. 1.53		(+3 -40 lines)
MODIFY	lib/sessionlib.php		Rev. 1.5		(+56 -1 lines)

Petr Skoda made changes - 02/Jan/09 11:52 PM

Link

This issue has a non-specific relationship to ~~MDL-17767~~ [ ~~MDL-17767~~ ]

Petr Skoda committed 13 files to 'Moodle CVS' - 03/Jan/09 05:32 AM

MDL-17754 next round of session related refactoring

MODIFY	lib/sessionlib.php	Rev. 1.9	(+74 -19 lines)
MODIFY	auth/ldap/auth.php	Rev. 1.70	(+1 -1 lines)
MODIFY	course/loginas.php	Rev. 1.55	(+2 -2 lines)
MODIFY	admin/generator.php	Rev. 1.20	(+1 -1 lines)
MODIFY	lib/weblib.php	Rev. 1.1194	(+5 -5 lines)
MODIFY	login/change_password.php	Rev. 1.70	(+2 -2 lines)
MODIFY	lib/moodlelib.php	Rev. 1.1138	(+9 -17 lines)
MODIFY	course/enrol.php	Rev. 1.56	(+2 -2 lines)
MODIFY	login/index.php	Rev. 1.140	(+2 -2 lines)
MODIFY	user/view.php	Rev. 1.200	(+4 -4 lines)
MODIFY	lib/accesslib.php	Rev. 1.564	(+7 -1 lines)
MODIFY	lib/datalib.php	Rev. 1.497	(+3 -3 lines)
MODIFY	lib/setup.php	Rev. 1.255	(+4 -32 lines)

Petr Skoda committed 8 files to 'Moodle CVS' - 03/Jan/09 06:05 AM

MDL-17772 fixed guest access; MDL-17754 $USER object initialisation cleanup

MODIFY	admin/cron.php	Rev. 1.154	(+2 -2 lines)
MODIFY	auth/mnet/land.php	Rev. 1.10	(+2 -2 lines)
MODIFY	lib/adminlib.php	Rev. 1.295	(+4 -4 lines)
MODIFY	lib/setup.php	Rev. 1.256	(+12 -9 lines)
MODIFY	lib/sessionlib.php	Rev. 1.10	(+2 -2 lines)
MODIFY	login/confirm.php	Rev. 1.35	(+3 -3 lines)
MODIFY	backup/lib.php	Rev. 1.108	(+2 -2 lines)
MODIFY	rss/file.php	Rev. 1.23	(+2 -4 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 03/Jan/09 06:27 AM

MDL-17754 $USER object initialisation cleanup

MODIFY

lib/moodlelib.php

Rev. 1.1140

(+2 -4 lines)

Petr Skoda made changes - 03/Jan/09 07:53 AM

Link

This issue has a non-specific relationship to ~~MDL-17773~~ [ ~~MDL-17773~~ ]

Petr Skoda committed 5 files to 'Moodle CVS' - 03/Jan/09 08:49 AM

~~MDL-16613~~ refactore session IP tracking; ~~MDL-14213~~ improved message when IP changes; MDL-17754 SID is regenerated when terminating session and old session is deleted

MODIFY	lib/sessionlib.php	Rev. 1.13	(+18 -12 lines)
MODIFY	lib/setup.php	Rev. 1.257	(+7 -6 lines)
MODIFY	lib/moodlelib.php	Rev. 1.1142	(+5 -7 lines)
MODIFY	lang/en_utf8/error.php	Rev. 1.151	(+2 -1 lines)
MODIFY	lib/weblib.php	Rev. 1.1196	(+3 -3 lines)

Petr Skoda made changes - 03/Jan/09 09:05 AM

Link

This issue has a non-specific relationship to ~~MDL-17774~~ [ ~~MDL-17774~~ ]

Petr Skoda made changes - 03/Jan/09 11:30 PM

Link

This issue has a non-specific relationship to ~~MDL-17776~~ [ ~~MDL-17776~~ ]

Petr Skoda made changes - 03/Jan/09 11:37 PM

Link

This issue has a non-specific relationship to ~~MDL-17777~~ [ ~~MDL-17777~~ ]

Petr Skoda made changes - 06/Jan/09 06:31 AM

Link

This issue has a non-specific relationship to ~~MDL-11061~~ [ ~~MDL-11061~~ ]

Petr Skoda made changes - 06/Jan/09 06:35 AM

Link

This issue has a non-specific relationship to ~~MDL-17787~~ [ ~~MDL-17787~~ ]

Petr Skoda committed 29 files to 'Moodle CVS' - 06/Jan/09 06:37 AM

MDL-17754, ~~MDL-11061~~, ~~MDL-9276~~, ~~MDL-17777~~, ~~MDL-17787~~ - various url handling improvemetns; rewritten $FULLME and added $ME, $SCRIPT and $FULLSCRIPT; improved slashargument handling especially for IIS; removed legacy slasharguments functions obsoleted since 1.6; some other refactoring; reverse procy support, ssl appliance support

MODIFY	lib/weblib.php	Rev. 1.1198	(+24 -161 lines)
MODIFY	file.php	Rev. 1.56	(+2 -2 lines)
MODIFY	question/exportfile.php	Rev. 1.4	(+1 -1 lines)
MODIFY	config-dist.php	Rev. 1.111	(+11 -1 lines)
MODIFY	course/report/participation/index.php	Rev. 1.29	(+2 -2 lines)
MODIFY	pluginfile.php	Rev. 1.6	(+2 -2 lines)
MODIFY	mod/choice/lib.php	Rev. 1.95	(+3 -3 lines)
DEL	user/Attic/pixgroup.php	Rev. 1.10	(+0 -0 lines)
MODIFY	blog/lib.php	Rev. 1.102	(+2 -2 lines)
MODIFY	lib/flickrlib.php	Rev. 1.5	(+3 -2 lines)
MODIFY	userfile.php	Rev. 1.8	(+2 -2 lines)
MODIFY	mod/scorm/report.php	Rev. 1.58	(+2 -2 lines)
MODIFY	filter/tex/pix.php	Rev. 1.34	(+2 -2 lines)
MODIFY	lib/filelib.php	Rev. 1.118	(+2 -2 lines)
MODIFY	lang/en_utf8/error.php	Rev. 1.152	(+4 -1 lines)
MODIFY	blocks/tags/block_tags.php	Rev. 1.14	(+3 -3 lines)
ADD	user/grouppix.php	Rev. 1.1	(+0 -0 lines)
MODIFY	install.php	Rev. 1.112	(+2 -2 lines)
MODIFY	draftfile.php	Rev. 1.8	(+2 -2 lines)
MODIFY	rss/file.php	Rev. 1.24	(+2 -2 lines)
MODIFY	lib/portfolio/exceptions.php	Rev. 1.4	(+3 -1 lines)
MODIFY	lib/setup.php	Rev. 1.259	(+10 -8 lines)
MODIFY	lib/installlib.php	Rev. 1.8	(+25 -1 lines)
MODIFY	lib/sessionlib.php	Rev. 1.16	(+2 -5 lines)
MODIFY	filter/algebra/pix.php	Rev. 1.24	(+2 -2 lines)
MODIFY	user/pix.php	Rev. 1.21	(+2 -2 lines)
MODIFY	question/file.php	Rev. 1.9	(+1 -1 lines)
MODIFY	lib/setuplib.php	Rev. 1.39	(+103 -2 lines)
MODIFY	admin/cron.php	Rev. 1.157	(+3 -4 lines)

Petr Skoda made changes - 06/Jan/09 07:39 AM

Link

This issue has a non-specific relationship to ~~MDL-17788~~ [ ~~MDL-17788~~ ]

Petr Skoda made changes - 06/Jan/09 10:18 PM

Link

This issue has a non-specific relationship to ~~MDL-14123~~ [ ~~MDL-14123~~ ]

martignoni committed 1 file to 'Lang CVS' - 11/Jan/09 05:33 PM

MDL-17754, ~~MDL-11061~~, ~~MDL-9276~~, ~~MDL-17777~~, ~~MDL-17787~~: new strings added

MODIFY

fr_utf8/error.php

Rev. 1.156

(+4 -1 lines)

Petr Skoda made changes - 15/Jan/09 03:44 AM

Link

This issue has a non-specific relationship to ~~MDL-17898~~ [ ~~MDL-17898~~ ]

Petr Skoda made changes - 07/Feb/09 07:57 PM

Link

This issue has a non-specific relationship to ~~MDL-8732~~ [ ~~MDL-8732~~ ]

Petr Skoda made changes - 07/Feb/09 07:57 PM

Link

This issue has been marked as being related by ~~MDL-17458~~ [ ~~MDL-17458~~ ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.