Issue Details (XML | Word | Printable)

Key: MDL-17758
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Petr Skoda
Reporter: Fran Szoro
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Hardcoded link in admin/index.php in Moodle 1.8.7+

Created: 01/Jan/09 04:32 AM   Updated: 06/Jan/09 11:51 AM
Return to search
Component/s: Administration
Affects Version/s: 1.8.7
Fix Version/s: 1.8.8, 1.9.4, 2.0

Environment: not related

Database: MySQL
Participants: Fran Szoro, Petr Skoda and Tim Hunt
Security Level: None
QA Assignee: Tim Hunt
Difficulty: Easy
Resolved date: 01/Jan/09
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Hi,

Since the latest build contains this bug, I report it.
Everyone is involved who's using 1.8.7+ and a different admin path (specified in the config.php: $CFG->admin).

I'm an upgrader from 1.6.3 to 1.8 and then to 1.9

The 1.8 upgrade is going well till paypal and then clicking on continue I get error 500. The admin site of moodle died.
Now, I tracked back the issue to a hardcoded link in admin/index.php line 429:
require_once($CFG->dirroot.'/admin/mnet/adminlib.php');

It seems to already be fixed in 1.9 latest, but not in 1.8.7+.
Thanks and Happy new year!


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda added a comment - 01/Jan/09 11:37 PM
fixed in cvs, thanks for the report!

Tim Hunt added a comment - 06/Jan/09 11:51 AM
Wow! great work Petr. I have not tested all these changes, but I have reviewed them, and they look good. I have also searched and can't find any more hard-coded admin paths.