[#MDL-17758] Hardcoded link in admin/index.php in Moodle 1.8.7+

Issue Details (XML | Word | Printable)

Key:	MDL-17758
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Major
Assignee:	Petr Skoda
Reporter:	Fran Szoro
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Hardcoded link in admin/index.php in Moodle 1.8.7+

Created: 01/Jan/09 04:32 AM Updated: 06/Jan/09 11:51 AM

Return to search

Component/s:

Administration

Affects Version/s:

1.8.7

Fix Version/s:

1.8.8, 1.9.4, 2.0

Environment:

not related

Database:	MySQL
Participants:	Fran Szoro, Petr Skoda and Tim Hunt
Security Level:	None
QA Assignee:	Tim Hunt
Difficulty:	Easy
Resolved date:	01/Jan/09
Affected Branches:	MOODLE_18_STABLE
Fixed Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

« Hide

Hi,

Since the latest build contains this bug, I report it.
Everyone is involved who's using 1.8.7+ and a different admin path (specified in the config.php: $CFG->admin).

I'm an upgrader from 1.6.3 to 1.8 and then to 1.9

The 1.8 upgrade is going well till paypal and then clicking on continue I get error 500. The admin site of moodle died.
Now, I tracked back the issue to a hardcoded link in admin/index.php line 429:
require_once($CFG->dirroot.'/admin/mnet/adminlib.php');

It seems to already be fixed in 1.9 latest, but not in 1.8.7+.
Thanks and Happy new year!

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda made changes - 01/Jan/09 11:23 PM

Field	Original Value	New Value
Assignee	moodle.com [ moodle.com ]	Petr ?koda [ skodak ]

Petr Skoda committed 22 files to 'Moodle CVS' - 01/Jan/09 11:25 PM

~~MDL-17758~~ fixed hardcoded /admin/ links

MODIFY	lib/portfoliolib.php	Rev. 1.67	(+1 -1 lines)
MODIFY	mod/resource/simpletest/Attic/test_resource_portfolio_callers.php	Rev. 1.5	(+4 -4 lines)
MODIFY	mod/forum/simpletest/test_forum_portfolio_callers.php	Rev. 1.5	(+4 -4 lines)
MODIFY	mod/glossary/simpletest/test_glossary_portfolio_callers.php	Rev. 1.5	(+3 -3 lines)
MODIFY	admin/report/unittest/index.php	Rev. 1.6	(+2 -2 lines)
MODIFY	lib/adminlib.php	Rev. 1.293	(+3 -3 lines)
MODIFY	repository/lib.php	Rev. 1.149	(+2 -2 lines)
MODIFY	portfolio/type/boxnet/simpletest/Attic/testportfoliopluginboxnet.php	Rev. 1.4	(+4 -4 lines)
MODIFY	admin/repository.php	Rev. 1.19	(+3 -3 lines)
MODIFY	grade/edit/settings/form.php	Rev. 1.8	(+4 -4 lines)
MODIFY	mod/assignment/simpletest/test_assignment_portfolio_callers.php	Rev. 1.6	(+4 -4 lines)
MODIFY	lib/simpletest/portfolio_testclass.php	Rev. 1.8	(+3 -6 lines)
MODIFY	mod/chat/simpletest/test_chat_portfolio_callers.php	Rev. 1.5	(+4 -4 lines)
MODIFY	lib/simpletest/testrepositorylib.php	Rev. 1.2	(+3 -3 lines)
MODIFY	lib/weblib.php	Rev. 1.1190	(+3 -3 lines)
MODIFY	admin/repositoryinstance.php	Rev. 1.7	(+4 -4 lines)
MODIFY	mod/data/simpletest/test_data_portfolio_callers.php	Rev. 1.5	(+4 -4 lines)
MODIFY	admin/Attic/cliupgrade.php	Rev. 1.30	(+3 -3 lines)
MODIFY	admin/report/capability/index.php	Rev. 1.10	(+3 -3 lines)
MODIFY	course/lib.php	Rev. 1.635	(+2 -2 lines)
MODIFY	admin/portfolio.php	Rev. 1.5	(+3 -3 lines)
MODIFY	admin/roles/tabs.php	Rev. 1.43	(+2 -2 lines)

Petr Skoda committed 3 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 01/Jan/09 11:29 PM

~~MDL-17758~~ fixed hardcoded /admin/ links

MODIFY	lib/weblib.php	Rev. 1.970.2.125	(+3 -3 lines)
MODIFY	grade/edit/settings/form.php	Rev. 1.2.2.5	(+4 -4 lines)
MODIFY	admin/roles/tabs.php	Rev. 1.27.2.6	(+2 -2 lines)

Petr Skoda committed 9 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 01/Jan/09 11:36 PM

~~MDL-17758~~ fixed hardcoded /admin/ links

MODIFY	blocks/admin_tree/block_admin_tree.php	Rev. 1.20.2.5	(+2 -2 lines)
MODIFY	admin/mnet/delete.html	Rev. 1.3.2.4	(+2 -2 lines)
MODIFY	admin/mnet/adminlib.php	Rev. 1.2.2.2	(+1 -1 lines)
MODIFY	admin/mnet/enr_hosts.php	Rev. 1.4.2.2	(+2 -2 lines)
MODIFY	admin/mnet/access_control.php	Rev. 1.12.2.2	(+5 -5 lines)
MODIFY	backup/backup_scheduled.php	Rev. 1.36.6.3	(+2 -2 lines)
MODIFY	admin/settings/mnet.php	Rev. 1.3.2.1	(+6 -6 lines)
MODIFY	admin/mnet/enr_courses.php	Rev. 1.5.2.3	(+2 -2 lines)
MODIFY	admin/index.php	Rev. 1.265.2.15	(+2 -2 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 01/Jan/09 11:37 PM

fixed in cvs, thanks for the report!

Petr Skoda made changes - 01/Jan/09 11:37 PM

Fix Version/s		1.8.8 [ 10314 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]
Fix Version/s		1.9.4 [ 10300 ]
Fix Version/s		2.0 [ 10122 ]

[ Permalink | « Hide ]

Tim Hunt added a comment - 06/Jan/09 11:51 AM

Wow! great work Petr. I have not tested all these changes, but I have reviewed them, and they look good. I have also searched and can't find any more hard-coded admin paths.

Tim Hunt made changes - 06/Jan/09 11:51 AM

Status	Resolved [ 5 ]	Closed [ 6 ]
QA Assignee		timhunt

All content on this web site is made available under the GNU General Public License, unless otherwise stated.