[#MDL-17777] Improve $FULLME, $ME and add $SCRIPT and $FULLSCRIPT

Issue Details (XML | Word | Printable)

Key:	MDL-17777
Type:	Task
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Improve $FULLME, $ME and add $SCRIPT and $FULLSCRIPT

Created: 03/Jan/09 11:36 PM Updated: 06/Jan/09 06:43 AM

Return to search

Component/s:

Administration

Affects Version/s:

2.0

Fix Version/s:

2.0

Issue Links:

Relates

This issue has been marked as being related by:

MDL-17754 Session improvements and related rewrites

Participants:	Petr Skoda
Security Level:	None
Resolved date:	06/Jan/09
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

The major problems here are:
* reverse proxies
* SSL accelerators

$FULLME - should always contain full url starting with wwwroot (and https: if https enabled) including page parameters and slasharguments
$ME - like FULLME but without the query part
$SCRIPT - relative me, like ME without wwwroot - ex: "/course/view.php", "/admin/cron.php"

the cron should stop using FULLME == 'cron' and instead use $SCRIPT == "/$CFG->admin/cron.php"

-------
This is just the first step towards reversed proxy and SSL accel support ;-)
This will also help with detection of incorrect access addresses.

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 29 files to 'Moodle CVS' - 06/Jan/09 06:37 AM

MDL-17754, ~~MDL-11061~~, ~~MDL-9276~~, ~~MDL-17777~~, ~~MDL-17787~~ - various url handling improvemetns; rewritten $FULLME and added $ME, $SCRIPT and $FULLSCRIPT; improved slashargument handling especially for IIS; removed legacy slasharguments functions obsoleted since 1.6; some other refactoring; reverse procy support, ssl appliance support

ADD	user/grouppix.php	Rev. 1.1	(+0 -0 lines)
MODIFY	question/file.php	Rev. 1.9	(+1 -1 lines)
MODIFY	config-dist.php	Rev. 1.111	(+11 -1 lines)
MODIFY	mod/choice/lib.php	Rev. 1.95	(+3 -3 lines)
MODIFY	lib/sessionlib.php	Rev. 1.16	(+2 -5 lines)
MODIFY	install.php	Rev. 1.112	(+2 -2 lines)
MODIFY	lib/installlib.php	Rev. 1.8	(+25 -1 lines)
MODIFY	pluginfile.php	Rev. 1.6	(+2 -2 lines)
MODIFY	lib/filelib.php	Rev. 1.118	(+2 -2 lines)
MODIFY	lib/flickrlib.php	Rev. 1.5	(+3 -2 lines)
MODIFY	lang/en_utf8/error.php	Rev. 1.152	(+4 -1 lines)
MODIFY	blocks/tags/block_tags.php	Rev. 1.14	(+3 -3 lines)
MODIFY	lib/setuplib.php	Rev. 1.39	(+103 -2 lines)
MODIFY	course/report/participation/index.php	Rev. 1.29	(+2 -2 lines)
MODIFY	rss/file.php	Rev. 1.24	(+2 -2 lines)
DEL	user/Attic/pixgroup.php	Rev. 1.10	(+0 -0 lines)
MODIFY	draftfile.php	Rev. 1.8	(+2 -2 lines)
MODIFY	filter/algebra/pix.php	Rev. 1.24	(+2 -2 lines)
MODIFY	lib/weblib.php	Rev. 1.1198	(+24 -161 lines)
MODIFY	user/pix.php	Rev. 1.21	(+2 -2 lines)
MODIFY	lib/setup.php	Rev. 1.259	(+10 -8 lines)
MODIFY	userfile.php	Rev. 1.8	(+2 -2 lines)
MODIFY	question/exportfile.php	Rev. 1.4	(+1 -1 lines)
MODIFY	file.php	Rev. 1.56	(+2 -2 lines)
MODIFY	blog/lib.php	Rev. 1.102	(+2 -2 lines)
MODIFY	filter/tex/pix.php	Rev. 1.34	(+2 -2 lines)
MODIFY	admin/cron.php	Rev. 1.157	(+3 -4 lines)
MODIFY	lib/portfolio/exceptions.php	Rev. 1.4	(+3 -1 lines)
MODIFY	mod/scorm/report.php	Rev. 1.58	(+2 -2 lines)