Moodle

Fatal error in cron.php during global search steps

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4, 2.0
  • Component/s: Global search
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

When running cron.php I get these messages:

Notice: Undefined variable: assignment in /srv/www/htdocs/moodle_19_fresh/search/documents/assignment_document.php on line 229

Notice: Trying to get property of non-object in /srv/www/htdocs/moodle_19_fresh/search/documents/assignment_document.php on line 229

Notice: Trying to get property of non-object in /srv/www/htdocs/moodle_19_fresh/search/documents/assignment_document.php on line 231

Notice: Undefined variable: assignment in /srv/www/htdocs/moodle_19_fresh/search/documents/assignment_document.php on line 231

Notice: Trying to get property of non-object in /srv/www/htdocs/moodle_19_fresh/search/documents/assignment_document.php on line 231

Fatal error: Call to a member function addField() on a non-object in /srv/www/htdocs/moodle_19_fresh/search/update.php on line 134

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Valery Fremaux added a comment -

Added protection to search/update.php when a single document is made for addition. Catched the case the document fails to be constructed.

Added a protection to the "submission" subtype when assignment fails to be retrieved :
TODO for fully closing :

  • analyze why submissions do not find their assignement
  • forward in 2.0 the fix
  • move MERGE tag on search/update.php and documents/assignement_document.php
Show
Valery Fremaux added a comment - Added protection to search/update.php when a single document is made for addition. Catched the case the document fails to be constructed. Added a protection to the "submission" subtype when assignment fails to be retrieved : TODO for fully closing :
  • analyze why submissions do not find their assignement
  • forward in 2.0 the fix
  • move MERGE tag on search/update.php and documents/assignement_document.php
Hide
Permalink
Tim Hunt added a comment -

Valery, please can you include the issue id (in this case MDL-17792) in the CVS commit message of any commit you do, so the tracker can identify the changes related to this bug (http://docs.moodle.org/en/Development:CVS_for_developers#CVS_commit_messages). It is impossible to review and test the changes you made to fix this. Please could you tell me which files you changed. Thanks.

Show
Tim Hunt added a comment - Valery, please can you include the issue id (in this case MDL-17792) in the CVS commit message of any commit you do, so the tracker can identify the changes related to this bug (http://docs.moodle.org/en/Development:CVS_for_developers#CVS_commit_messages). It is impossible to review and test the changes you made to fix this. Please could you tell me which files you changed. Thanks.
Hide
Permalink
Valery Fremaux added a comment -

Oh terribly sorry. I have not taken the habits yet. I must care a bit more my practices. I've not yet in mind that you track the commit logs for getting control of pending tracker entries. I should remember that. The factis that I often cannot keep in mind all tracker entries, specially on global search for which very old entries are mixing concerns with recent issues. I asked for a work session about that, but was never pinged for.

both files mentionned in above error message were updated for this one. It should be an isolated commit after the big update of global search in branches MOODLE_19_STABLE and MOODLE_HEAD.

Cheers.

Show
Valery Fremaux added a comment - Oh terribly sorry. I have not taken the habits yet. I must care a bit more my practices. I've not yet in mind that you track the commit logs for getting control of pending tracker entries. I should remember that. The factis that I often cannot keep in mind all tracker entries, specially on global search for which very old entries are mixing concerns with recent issues. I asked for a work session about that, but was never pinged for. both files mentionned in above error message were updated for this one. It should be an isolated commit after the big update of global search in branches MOODLE_19_STABLE and MOODLE_HEAD. Cheers.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.