|
[
Permalink
| « Hide
]
Kenneth Newquist added a comment - 08/Jan/09 01:11 AM
Just to clarify, is the goal here to actually incorporate the LSU gradebook changes into core itself, or to create a series of patches that allow it to be more easily used with core?
well this is still subject to testing and review. I think that by tomorrow we'll have a live test install with the LSU gradebook running, so that people can test and give feedback.
There are some obvious concerns regarding the compatibility of this "patch" with existing code in core. Ideally we would like to take the best stuff from LSU gradebook and merge into core (extra weights, curving, sticky tabs are the main features), but we're not sure if this is feasible for 1.9 yet. [bump]
Any progress on this? Is there a test install available anywhere? Hi Kenneth. I've just applied the LSU gradebook patch to a copy of the 1.9 moodle test site (it uses the same database). You can use it by reaching http://test.moodle.org/lsugradebook
Hi Nicolas, I get 'Sorry, but you do not currently have permissions to do that (View the gradebook)' when trying to view Quick Edit Items or Quick edit Categories. Which parts of the LSU gradebook are available on the http://test.moodle.org/lsugradebook
Barry, you need a special "Tester" role to be able to test everything. Please send me an email with your desired username and email address, and I will create an account for you which will work on this test site as well as the 1.9 site (shared database).
Petr Skoda made changes - 22/Jan/09 02:58 AM
Petr Skoda made changes - 22/Jan/09 02:58 AM
Thanks for the profile Nicolas. I can't see any difference now that I log in with my own profile. What am I missing?
Hi Barry, I've just given you teacher rights to http://test.moodle.org/lsugradebook/course/view.php?id=5
Thanks for helping with testing. Hi Helen, thanks for that. I can't see anything new even with my new powers. What should I be looking for? I still get the same error I mentioned before.
I just realised that I needed to bump the version.php file in the simple_grader report. This triggered the proper installation of the LSU gradebook. You should now be able to see the patch in action.
Thanks, everything seems to be working now.
Helen Foster made changes - 23/Jan/09 01:01 AM
it is just me? I do not see the horizontal ruler in LSU gradebook via View > Gradebook (any browser)
hm, disregard my previous comment
On http://test.moodle.org/1.9/grade/report/grader/index.php?id=2
Helen Foster made changes - 29/Jan/09 10:26 PM
Have you thought of any way to do sticky headers?
Making sticky headers would be a major usability issue if sticky columns were also enabled. This would put a horizontal scroll bar as well as a vertical one, meaning that the table content could end up at any position between left, right, top and bottom boundaries. I really can't see any advantage to this idea.
Besides, it's not possible without a heap of JS, and probably a week of work. Not worth it IMO. How about mirroring the headers at the bottom of the page? Otherwise we can't see which column we're looking at when we scroll left and right with lots of students.
Or is the only solution to tell people to remember to limit the number of students per page? That brings it's own set of challenges like how do you navigate to the students who are on the other pages? You have to click through page numbers to find them. We need a workaround and I guess I'll keep on thinking of ideas. Hope it's helping rather than hindering Barry,
Of course you're not hindering! What a silly idea Someone in the forum suggested an alphabetical filter like the one used in the admin user search page. This would make it easier to find students. And of course we could put the headers at the bottom, but it would look rather awkward I think, if you have 4 levels of categories... Plus you would need to mirror them completely, so that the top-level categories would be output at the bottom. Maybe you could put together a mock (on paper or html) to see what it would look like. I'm not convinced that this is the best solution. GBv2 had a setting that allowed "repeat headers every x rows" which covered every eventuality.
"repeat headers every x rows" would mean less clicking and less having to limit students by page etc so looks like a win-win situation. Was 'x' a set number or was it dependent on other factors?
'x' was defaulted to zero (but configurable sitewide by admin) and settable by instructor per course.
Nicolas Connault made changes - 03/Feb/09 03:20 PM
I am transferring this from the forum, so it will not get lost.
I have to say that not having the horizontal stroller right inside the browser window is cumbersome. Another idea: Have two options:
1. If the number of students per page is set to a small number like 10 then, enable sticky column and add A-Z navigation to find students 2. If more students per page: For option 2 you'll have these benefits: I agree with Barry, and I think that those options should go into the (my viewing) Preferences or Course (gradebook) Settings.
Do it similar to 1.8 Preferences:
To have only the grade items repeated from the headers might be a problem for people who's grade items have the same name e.g.
The categories would help tell them apart. I see the point.. so goes saving space...
I personally think that people should give good descriptive names to the items anyway (but who would listen..) p.s.
Elena,
Nicolas, I guess, we'd need new database fields for settings options like these in the interface. Does that affect anything? grade/report/simple_grader/lib/grade_sql.php:
Fixed bug responsible for displaying items instead of categories in the quick edit categories page on test.moodle.org. Please update test.moodle.org. No other files need to be updated besides the following 2: grade/report/simple_grader/quick_edit.php has been updated in CVS Love the improvements, but I second Elena's comment about the missing scrollbar - it's a real pain. I suggest a small bit of js using yui's event and animation utilities so that as the mouse is rolled over the left or right of the screen, the gradebook automatically scrolls in that direction. Alternatively, click to drag could work, with a clause added to the listener that it should not operate if one of the editing icons is clicked.
I've also just noticed that the click-to-highlight function ignores the first column and that there are missing CSS bits for cells that are both manually altered and highlighted.
Nicolas Connault committed 36 files to 'Moodle CVS' - 09/Feb/09 07:49 PM
Nicolas Connault committed 1 file to 'Moodle CVS' - 11/Feb/09 11:29 PM
This is implemented in HEAD. Thanks for your feedback, please keep it coming.
Just went to http://test.moodle.org/1.9/grade/report/grader/index.php?id=2
and got Fatal error: Call to a member function is_excluded() on a non-object in /var/www/html/test/1.9/lib/grade/grade_grade.php on line 631
Helen Foster made changes - 12/Feb/09 09:39 PM
Helen Foster made changes - 12/Feb/09 09:42 PM
Helen Foster made changes - 12/Feb/09 10:17 PM
Thanks everyone for your comments.
To return to Kenneth's initial comment about whether the goal is to incorporate the LSU gradebook changes into core, or to create a series of patches that allow it to be more easily used with core, as the LSU gradebook includes a number of features, it seems easiest to track these as separate issues. Thanks to everyone who has voted for this issue. Please consider voting for individual features of the LSU gradebook which are listed as related issues - If there are additional features of the LSU gradebook which you'd like included in core, please create separate issues for them. I'm removing 1.9.5 as the fix version for this issue, since to make changes in core so that LSU gradebook does not need hacks in core (the title of this issue) would require database changes which can only happen in Moodle 2.0.
Helen Foster made changes - 12/Feb/09 11:16 PM
Just to clarify Nicolas' comment "This is implemented in HEAD", Nicolas is referring to the horizontal scrollbar -
Nicolas Connault committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 22/Apr/09 04:25 PM
Nicolas Connault committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 22/Apr/09 04:34 PM
Nicolas Connault committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 22/Apr/09 04:39 PM
Nicolas Connault committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 22/Apr/09 04:40 PM
Nicolas Connault made changes - 08/May/09 02:01 PM
Nicolas Connault made changes - 08/May/09 11:13 PM
Removing 1.9.6 fix version. Apologies for the spam.
Helen Foster made changes - 09/May/09 12:21 AM
Martin Dougiamas made changes - 13/Nov/09 04:08 PM
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||