Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.9.3
-
Fix Version/s: 1.9.5
-
Component/s: Authentication, Language
-
Labels:None
-
Difficulty:Easy
-
Affected Branches:MOODLE_19_STABLE
-
Fixed Branches:MOODLE_19_STABLE
Description
Hello
In some countries, for example Germany where I am from, it's necessary to include the users lastname during correspondence - for example mails. The maintainers of the German language pack have included the necessary variables in the mail text ( $string['emailpasswordconfirmation'] = 'Guten Tag $a->firstname $a->lastname ). As this did not solve the problem and still only the first name was included into the mails, I looked up the code that is responsible for sending the mails. There I found the reason and was able to fix it for me.
I'd suggest to include this in the main code of Moodle. The fix would be in the function send_password_change_confirmation_mail() in file /lib/moodlelib.php at line 4469. Here it would be fine to include the line:
$data->lastname = $user->lastname;
At least for me it would be fine to have this in the main-code so I do not have to patch the code after every update 
.
Andreas
fixed in cvs, thanks a lot!